Feat/add safe t1004 server impersonation#127
Open
geekysatbir wants to merge 9 commits intosafe-agentic-framework:mainfrom
Open
Feat/add safe t1004 server impersonation#127geekysatbir wants to merge 9 commits intosafe-agentic-framework:mainfrom
geekysatbir wants to merge 9 commits intosafe-agentic-framework:mainfrom
Conversation
Added practical Python code examples demonstrating: - Simple loop detection using call history tracking - Basic loop prevention with iteration limits and convergence checks - Log pattern analysis for identifying loop indicators This addition helps beginners understand autonomous loop exploits through hands-on, runnable code examples. Signed-off-by: Satbir Singh <satbisin@cisco.com>
Signed-off-by: Satbir Singh <satbisin@cisco.com>
Signed-off-by: Satbir Singh <satbisin@cisco.com>
… documentation - Added comprehensive documentation for SAFE-T1004 technique - Includes attack vectors, technical details, detection methods, and mitigations - Created Sigma-format detection rule for identifying server impersonation attacks - Updated main README to link to new technique documentation This technique documents how attackers impersonate trusted MCP servers through name collision, DNS hijacking, and discovery service manipulation to gain initial access to MCP environments. Signed-off-by: Satbir Singh <satbir.taya84@gmail.com>
…us sections - Expanded Advanced Attack Techniques with more detailed explanations - Enhanced Current Status section with specific implementation details - Improved clarity and alignment with SAFE-T1008 format Signed-off-by: Satbir Singh <satbir.taya84@gmail.com>
arjunastha
reviewed
Nov 17, 2025
techniques/SAFE-T1004/README.md
Outdated
|
|
||
| ## Related Techniques | ||
| - [SAFE-T1002](../SAFE-T1002/README.md) – Supply Chain Compromise (related but focuses on package compromise rather than server impersonation) | ||
| - [SAFE-T1003](../SAFE-T1003/README.md) – Malicious MCP-Server Distribution (related but involves creating new malicious servers rather than impersonating existing ones) |
Collaborator
There was a problem hiding this comment.
@geekysatbir Currently these link route to 404. Please fix routing issue.
Fixed relative paths to use absolute paths from repository root to resolve 404 errors in GitHub PR view. Signed-off-by: Satbir Singh <satbir.taya84@gmail.com>
Changed from absolute paths (techniques/SAFE-TXXXX/README.md) to relative paths (../SAFE-TXXXX/README.md) to match the format used by other techniques in the repository. This ensures links work correctly when viewing files in GitHub's web interface. Signed-off-by: Satbir Singh <satbir.taya84@gmail.com>
geekysatbir
force-pushed
the
feat/add-safe-t1004-server-impersonation
branch
from
41a36a4 to
2f73911
Compare
Signed-off-by: Satbir Singh <satbir.taya84@gmail.com>
- Resolved conflicts by accepting upstream version for SAFE-T1004 (already merged by another contributor) - README.md merged automatically Signed-off-by: Satbir Singh <satbisin@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive documentation for SAFE-T1004: Server Impersonation / Name-Collision, a technique where attackers register or advertise malicious MCP servers using identical names or identifiers as trusted ones, exploiting weaknesses in naming systems (DNS, mDNS, or MCP's On-Device Agent Registry) to gain initial access.
What's Added
Key Features:
Technical Highlights:
71aa869b-65cc-47f3-ada5-d9e67337dc44) for identifying server impersonation patternsValue Proposition:
This documentation addresses a critical initial access vector in MCP environments, helping security teams understand how attackers exploit naming system weaknesses to impersonate trusted servers. The technique is particularly relevant for organizations deploying MCP servers in enterprise environments where discovery mechanisms like DNS, mDNS, and ODR are commonly used.
Type of Contribution
Testing
Related Techniques
References