fix: post-1.2.1 hardening (OCR redaction, adaptive FPS, thread-safety, pip-audit in CI)#249
Conversation
…, pip-audit in CI) - Implemented OCR redaction in VisionSubsystem, ensuring safe_ocr is used in pipeline and events. - Added adaptive FPS throttling via _calculate_sleep. - Reinforced thread-safety in SessionBlackboard, AuditLog, and ConsentManager. - Renamed SessionBlackboard.add_fact parameters to (fact, score, source). - Added pip-audit security step to CI workflow. - Added comprehensive hardening verification tests. Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Implemented OCR redaction in VisionSubsystem with PII masking. - Added adaptive FPS throttling (target_fps=2.0). - Reinforced thread-safety in Blackboard, AuditLog, and ConsentManager. - Renamed SessionBlackboard.add_fact parameters to (fact, score, source). - Configured Dependabot and Dependency Review. - Enabled CodeQL static analysis. - Upgraded CI to a full Security Pipeline with SBOM (CycloneDX) and pip-audit. - Implemented reproducible builds using pip-tools (requirements.in/txt). - Added pre-commit hooks for security and code quality. - Added comprehensive hardening verification tests. Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out |
- Consolidated CI into a single Security & CI Pipeline with CodeQL, pip-audit, and SBOM. - Implemented OCR redaction with PII masking in VisionSubsystem. - Added adaptive FPS throttling (target_fps=2.0). - Reinforced thread-safety in Blackboard, AuditLog, and ConsentManager. - Updated SessionBlackboard.add_fact parameters to (fact, score, source). - Configured Dependabot for automated dependency updates. - Implemented reproducible builds using pip-tools. - Added pre-commit hooks for local security and quality checks. - Added comprehensive hardening verification tests. Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
- Consolidated CI into a single Security & CI Pipeline with CodeQL, pip-audit, and SBOM. - Implemented OCR redaction with PII masking in VisionSubsystem. - Added adaptive FPS throttling (target_fps=2.0). - Reinforced thread-safety in Blackboard, AuditLog, and ConsentManager. - Updated SessionBlackboard.add_fact parameters to (fact, score, source). - Configured Dependabot for automated dependency updates. - Implemented reproducible builds using pip-tools. - Added pre-commit hooks for local security and quality checks. - Added comprehensive hardening verification tests. Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
- Consolidated CI into a single Security & CI Pipeline with CodeQL, pip-audit, and SBOM. - Implemented OCR redaction with PII masking in VisionSubsystem. - Added adaptive FPS throttling (target_fps=2.0). - Reinforced thread-safety in Blackboard, AuditLog, and ConsentManager. - Updated SessionBlackboard.add_fact parameters to (fact, score, source). - Configured Dependabot for automated dependency updates. - Implemented reproducible builds using pip-tools. - Added pre-commit hooks for local security and quality checks. - Added comprehensive hardening verification tests. Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
- Consolidated Security & CI Pipeline in .github/workflows/ci.yml with CodeQL, pip-audit, and SBOM. - Enhanced VisionSubsystem (python/modules/perception/coordinator.py) with adaptive FPS, OCR redaction, and crash-resilient loop. - Reinforced thread-safety in Blackboard, AuditLog, and ConsentManager with documented Lock usage. - Implemented reproducible builds with pip-tools (requirements.in/txt). - Added .pre-commit-config.yaml and a dedicated .git/hooks/pre-commit script. - Verified all hardening measures with comprehensive tests. Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
- Consolidated CI into a single Security & CI Pipeline with CodeQL, pip-audit, and SBOM. - Enhanced VisionSubsystem with adaptive FPS, robust OCR redaction, and crash protection. - Reinforced thread-safety in Blackboard, AuditLog, and ConsentManager. - Transitioned to pip-tools for reproducible builds (requirements.in/txt). - Configured Dependabot and pre-commit hooks for security and quality. - Added comprehensive hardening verification tests. Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
- Unified CI Pipeline with system dependencies (portaudio19-dev, build-essential) and Python 3.11. - Integrated CodeQL, pip-audit (CVE auditing), and CycloneDX SBOM generation. - Hardened VisionSubsystem with adaptive FPS throttling, robust OCR redaction, and crash-resilient capture loop. - Reinforced thread-safety in Blackboard, AuditLog, and ConsentManager. - Implemented reproducible builds with pip-tools and automated weekly maintenance via Dependabot. - Configured pre-commit hooks for ruff, black, and pytest. - Added comprehensive verification tests in tests/test_hardening_verification.py. Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
- VisionSubsystem: Added adaptive FPS (2.0), PII OCR redaction, and crash-resilient loop. - Thread-Safety: Reinforced state protection in Blackboard, AuditLog, and ConsentManager. - CI/CD: Consolidated tests, CodeQL, pip-audit, and SBOM into a single Python 3.12 pipeline. - Supply Chain: Integrated pip-tools (requirements.in) and automated updates via Dependabot. - Local QA: Added ruff-based pre-commit hooks and dedicated hardening tests. Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
This PR implements several security and performance hardening measures following the 1.2.1 release.
Key changes:
VisionSubsystemto ensure that OCR text extracted from frames is redacted before being processed by the vision pipeline or emitted to the event bus. This prevents sensitive information like emails and passwords from leaking into logs or downstream components.target_fps(defaulting to 2.0).SessionBlackboard.add_fact,AuditLog.log_event, andConsentManager.is_capture_allowednow consistently use locks to protect shared state. Method parameters foradd_factwere updated to(fact, score, source)as requested.pip-audit.tests/test_hardening_verification.pyto specifically verify the new hardening measures, including PII redaction, FPS accuracy, and concurrent access safety.PR created automatically by Jules for task 11226761085530156998 started by @safal207