Skip to content

fix(semver): compare pre-release strings #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2025
Merged

fix(semver): compare pre-release strings #169

merged 5 commits into from
Aug 2, 2025

Conversation

leelhn2345
Copy link
Contributor

@leelhn2345 leelhn2345 commented Aug 2, 2025 •
edited
Loading

fixes #139

image

@leelhn2345 leelhn2345 mentioned this pull request Aug 2, 2025
Closed
saecki
saecki reviewed Aug 2, 2025
View reviewed changes
Copy link
Owner

@saecki saecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this work! I've just got one nitpicky comment :)

@leelhn2345 leelhn2345 marked this pull request as draft August 2, 2025 13:02
@leelhn2345 leelhn2345 marked this pull request as ready for review August 2, 2025 13:05
@leelhn2345
Copy link
Contributor Author

ok done with the changes 😄

@saecki
Copy link
Owner

saecki commented Aug 2, 2025

Oh, good catch!

@saecki saecki merged commit 0557ec4 into saecki:main Aug 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saecki saecki saecki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly compare pre-release strings
3 participants
@leelhn2345 @saecki @nelsonacsg