Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Banner component to the docs ecosystem (types + registry wiring + demos), and updates the Radix Button styling/implementation to support the new component and updated design tokens.
Changes:
- Introduces new Banner type definitions for both Radix and Base docs type tables.
- Registers the Banner component in the Radix UI registry and adds two Radix demo examples (single + stacked/queued).
- Updates the Radix
Buttonimplementation/styles (Slot usage, variants/sizes, and data attributes).
Reviewed changes
Copilot reviewed 66 out of 66 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/types/radix/banner.ts | Adds Radix Banner public type surface used by docs type tables. |
| docs/types/base/banner.ts | Adds Base Banner public type surface used by docs type tables. |
| docs/registry/bases/radix/ui/button.tsx | Updates Button variants/sizes and switches Slot usage; adds data-variant/data-size. |
| docs/registry/bases/radix/ui/_registry.ts | Registers the new banner UI item and its registry dependencies. |
| docs/registry/bases/radix/examples/banner-demo.tsx | Adds a simple controlled Banner example for the docs site. |
| docs/registry/bases/radix/examples/banner-stacked-demo.tsx | Adds a queued/stacked Banners provider demo using useBanners(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.