Missing plugin settings in LightGalleryAllSettings

[pascal-brand38]

Settings of the plugins:
Relative Caption
Vimeo Thumbnails
have been added to LightGalleryAllSettings

Fixes #1723

Summary by CodeRabbit

• New Features
  • Expanded settings options to include support for Relative Caption and Vimeo Thumbnail configurations.

[coderabbitai]

Walkthrough

The changes update the src/lg-settings.ts file by importing RelativeCaptionSettings and VimeoThumbnailSettings, and adding them to the LightGalleryAllSettings type union. This extends the configuration type to include settings for the Relative Caption and Vimeo Thumbnails plugins.

Changes

File(s)	Change Summary
src/lg-settings.ts	Imported RelativeCaptionSettings and VimeoThumbnailSettings, and added both to the LightGalleryAllSettings type union.

Assessment against linked issues

Objective	Addressed	Explanation
Add RelativeCaptionSettings and VimeoThumbnailSettings to LightGalleryAllSettings (#1723)	✅

Poem

A hop and a skip, some settings anew,
Now captions and thumbnails join the crew!
With types extended, the gallery’s bright,
Plugins in place, everything’s right.
🐇✨

— A rabbit who loves well-typed light

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92717fc and ad1249f.

📒 Files selected for processing (1)

• src/lg-settings.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/lg-settings.ts (2)

src/plugins/relativeCaption/lg-relative-caption-settings.ts (1)

• RelativeCaptionSettings (1-6)

src/plugins/vimeoThumbnail/lg-vimeo-thumbnail-settings.ts (1)

• VimeoThumbnailSettings (1-11)

🔇 Additional comments (5)

src/lg-settings.ts (5)

10-10: LGTM: Import statement correctly added.

The import for RelativeCaptionSettings follows the established pattern and uses the correct path structure.

---

15-15: LGTM: Import statement correctly added.

The import for VimeoThumbnailSettings follows the established pattern and uses the correct path structure.

---

56-56: LGTM: Type correctly added to settings union.

The RelativeCaptionSettings is properly added to the LightGalleryAllSettings union type, maintaining the established alphabetical ordering.

---

59-59: LGTM: Type correctly added to settings union.

The VimeoThumbnailSettings is properly added to the LightGalleryAllSettings union type, maintaining the established alphabetical ordering.

---

24-35: Verify mobile settings coverage for new plugins

It appears we’re still missing plugin-specific mobile settings in MobileSettings (e.g. VimeoThumbnailSettings, RelativeCaptionSettings), despite the // @todo use separate mobile settings for plugins on line 23. Please confirm whether these plugins need mobile configurations and, if so, add them.

• File: src/lg-settings.ts
• Lines: 24–35

Suggested diff if mobile options are required:

 export interface MobileSettings
   extends LightGalleryCoreMobileSettings,
           Partial<ZoomSettings>,
           Partial<ThumbnailsSettings>,
           Partial<VideoSettings>,
+          Partial<VimeoThumbnailSettings>,
+          Partial<RelativeCaptionSettings>,
           Partial<AutoplaySettings>,
           Partial<CommentSettings>,
           /* … */
 {}

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pascal-brand38]

@sachinchoolur anythings wrong in the PR?
Can I help / update to improve the code so that it is merged?

Thanks,
Pascal.