Support dired-subtree#13
Conversation
dired-subtree repositry is https://github.com/Fuco1/dired-hacks
|
ping |
There was a problem hiding this comment.
Perhaps
(unless (and (fboundp 'dired-subtree--get-ov)
(dired-subtree--get-ov))
)
? It covers both cases, and I'd rather avoid loading a package.
There was a problem hiding this comment.
Yes.
(require 'dired-subtree nil t) covers both case.
dired-subtree--get-ov may chage on upstream.
There was a problem hiding this comment.
AFAIK, require will try to find the package in the filesystem, if it's not loaded. Which is not an option in a loop.
You are using dired-subtree--get-ov anyway. Should upstream change fboundp is more likely to fail silently -- which I think is more desirable.
There was a problem hiding this comment.
If dired-subtree is loaded, dired-subtree--get-ov is defined, and (featurep 'dired-subtree) returns t .
This branch never uses dired-subtree--get-ov as long as load dired-subtree
There was a problem hiding this comment.
What you wrote is not equivalent to featurep. It's extremely slow if it the library is not installed.
There was a problem hiding this comment.
I understood what you say. Thanks.
I commit myuhe@aa139e2 that fix it.
See it.
There was a problem hiding this comment.
You are no longer checking if you are within a subtree
There was a problem hiding this comment.
If dired-subtree--get-ov is defined, dired-subtree should be loaded.
Is fboundp more desireble, isn't it?
There was a problem hiding this comment.
Didn't you mean to write this?
(and (fboundp 'dired-subtree--get-ov)
(dired-subtree--get-ov))
, with (dired-subtree--get-ov) testing whether inside a subtree?
There was a problem hiding this comment.
Thanks.
I fixed it again. myuhe@3a980dd
check it.
There was a problem hiding this comment.
Now that I see it again, this looks convoluted -- you have an extra unneeded conditional. You probably want not instead of unless. Or even better, remove the negation, and reverse the clauses.
There was a problem hiding this comment.
I messed it up... Thanks.
FIxed it.
There was a problem hiding this comment.
Please Check it again.
|
Sorry, I'm being a crappy maintainer. I've played with it a bit. Is your goal basically to remove stripes from the subtrees? If yes, skipping is quite easy. It's likely also a better solution, since having subtle colour variations mean different things is likely to be more confusing than helpful for most people. |
|
Why is "more confusing"? If Try to use subtree_support branch. |
|
That is the branch I've tested. Could you post a screenshot of your setup, showing different directories open? |
|
Here it is.
|
|
ping again. |
|
That's fine, there is a small bug, I'll merge your changes along with the fix. |
|
Thanks! |
|
Any chance for merging this? Looks useful. |
3 participants
dired-subtree repositry is here.