-
Notifications
You must be signed in to change notification settings - Fork 53
Add several customization variables #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
notetiene
wants to merge
16
commits into
sabof:master
Choose a base branch
from
notetiene:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
32b7b27
Remove code that tries to hide leading stars.
Kaligule b4cef1a
Added documentation about hiding leading stars to README.
Kaligule c9f34fa
Add docstring
notetiene bf42142
Add customization options
notetiene 2fb1db0
Refactor fontification function calls
notetiene 4fc565a
Add indentation
notetiene 8dd207d
Remove unused import
notetiene 7ac3916
Add mouse-face to level region
notetiene 551e2fa
Add leading star options
notetiene 585f1d7
Refactor bullet events
notetiene 308acbb
Add option to remove org-bullets events
notetiene 25c65c0
Fix initial value error
notetiene 60e996b
Support lexical scoping
notetiene 0d9490b
Add docstring
notetiene 5a21e91
Bump version
notetiene 905378c
Update packaging meta-data
notetiene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the added complexity of providing two different behaviors here worth it? Why would a user choose one option instead of the other?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same behavior. Nothing changed except I specified a better customization type. This allows auto-completion of faces.
Could you please explain what you mean? I probably don't understand what you said.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that faces are symbols doesn't mean this variable allows all symbols. Nil is also a (constant) symbol.
In order to provide completion for both nil and symbol faces, I need to make a composite type.
However, this does not make the variable typed or restrict in any way setting the variable to any other types.
:typekeywords indefcustomare only useful when using thecustomizeinterface.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't realize this was a previously available option. You may disregard my commentary :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway thanks for reviewing that at least 😂