Fix: Saving files in custom data dir not working on Android #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge permission granting
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
- Coverage 47.09% 46.95% -0.14%
==========================================
Files 114 114
Lines 9003 9029 +26
==========================================
Hits 4240 4240
- Misses 4763 4789 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
adil192
reviewed
May 31, 2025
| @@ -114,15 +115,52 @@ class _DirectorySelectorState extends State<DirectorySelector> { | |||
|
|
|||
| final dir = Directory(directory); | |||
| _directory = directory; | |||
| _isEmpty = dir.existsSync() ? dir.listSync().isEmpty : true; | |||
| _isEmpty = (dir.existsSync() ? dir.listSync().isEmpty : true) || true; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes not being able to save or see certain notes when saving in a custom data directory by requesting the MANAGE_EXTERNAL_STORAGE permission when you select a custom data directory.
This way notes can be synced via Syncthing and more.
Closes #1223
Replaces #1442