fix(badge): calculate inline padding based on --size-selector #4296
+3
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keeps the badge aspect 1:1 when empty - simplifies the CSS close saadeghi#4293
simoami
approved these changes
Nov 16, 2025
@pdanpdan I think this is a problem with components that have an expected aspect ratio that ends up being broken due to theme size adjustments. I don't think the other components you mentioned have a case where aspect ratio needs to be locked. |
pdanpdan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4293
It looks like button, kbd, and tab also have size based on multiples of --size-fiels or --size-selector and paddings based on multiples of 0.25rem.
Should we also convert them to use inline padding based on --size-fiels or --size-selector?