feat(docs): work on theme picker #4286
Open
+65
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in tailwind palette neutral-50 and zinc-50 are identical pick neutral-50 because it is more meaningfull
color has duplicates zinc-50 and neutral-50
svelte reactivity is not very funny the effects are called right when the value changes (not batched), and we have to be very carefull with the order different state values are changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix and optimize inputValue processing in ColorPalette
use a single handleKeydown listener in ColorPalette
use colorName as key to mark colors as selected
make sure we pick neutral-50 instead of zinc-50
avoid bind:value in ThemeCSSModal because we already have a listener on it