CaloTowerStatus - Add Input Node Option#4183
Merged
bseidlit merged 1 commit intosPHENIX-Collaboration:masterfrom Feb 20, 2026
Merged
CaloTowerStatus - Add Input Node Option#4183bseidlit merged 1 commit intosPHENIX-Collaboration:masterfrom
bseidlit merged 1 commit intosPHENIX-Collaboration:masterfrom
Conversation
- Allow for providing a generic input node name that does not strictly adhere to the suffix from `m_detector`. - By default this is empty and does not override existing functionality unless explicity set via the `set_inputNode` method.
There was a problem hiding this comment.
Pull request overview
This PR adds flexibility to the CaloTowerStatus class by allowing users to specify a custom input node name that overrides the default naming convention (prefix + detector suffix). This enables the class to work with tower containers that don't follow the standard naming pattern.
Changes:
- Added a new setter method
set_inputNode()to allow explicit specification of the input node name - Added a private member variable
m_inputNodeto store the custom node name - Modified the
CreateNodeTree()method to use the custom node name when provided, falling back to the prefix + detector pattern otherwise
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| offline/packages/CaloReco/CaloTowerStatus.h | Added setter method and member variable for custom input node name |
| offline/packages/CaloReco/CaloTowerStatus.cc | Implemented logic to use custom input node name when set, otherwise use default naming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Build & test reportReport for commit 0a29355aa458408d1454b959fdebe49a319810fd:
Automatically generated by sPHENIX Jenkins continuous integration |
d489ba9
into
sPHENIX-Collaboration:master
26 of 27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
m_detector.set_inputNodemethod.TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)