Skip to content

CaloTowerStatus - Add Input Node Option#4183

Merged
bseidlit merged 1 commit intosPHENIX-Collaboration:masterfrom
Steepspace:CaloTowerStatus-feat
Feb 20, 2026
Merged

CaloTowerStatus - Add Input Node Option#4183
bseidlit merged 1 commit intosPHENIX-Collaboration:masterfrom
Steepspace:CaloTowerStatus-feat

Conversation

@Steepspace
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

  • Allow for providing a generic input node name that does not strictly adhere to the suffix from m_detector.
  • By default this is empty and does not override existing functionality unless explicity set via the set_inputNode method.

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

- Allow for providing a generic input node name that does not strictly adhere to the suffix from `m_detector`.
- By default this is empty and does not override existing functionality unless explicity set via the `set_inputNode` method.
Copilot AI review requested due to automatic review settings February 18, 2026 17:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds flexibility to the CaloTowerStatus class by allowing users to specify a custom input node name that overrides the default naming convention (prefix + detector suffix). This enables the class to work with tower containers that don't follow the standard naming pattern.

Changes:

  • Added a new setter method set_inputNode() to allow explicit specification of the input node name
  • Added a private member variable m_inputNode to store the custom node name
  • Modified the CreateNodeTree() method to use the custom node name when provided, falling back to the prefix + detector pattern otherwise

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
offline/packages/CaloReco/CaloTowerStatus.h Added setter method and member variable for custom input node name
offline/packages/CaloReco/CaloTowerStatus.cc Implemented logic to use custom input node name when set, otherwise use default naming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sphenix-jenkins-ci
Copy link

Build & test report

Report for commit 0a29355aa458408d1454b959fdebe49a319810fd:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@bseidlit bseidlit merged commit d489ba9 into sPHENIX-Collaboration:master Feb 20, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments