Add POST Policy validation for browser-based S3 uploads #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created comprehensive E2E tests for POST object with policy validation - Tests cover: basic upload, conditions, content-length-range, starts-with, expired policy, invalid bucket - Added required dependencies: time, serde_json, hmac, sha2, hex Co-authored-by: Nugine <[email protected]>
- Created post_policy module to parse and validate POST policies - Added policy expiration validation - Added policy condition validation (exact match, starts-with, content-length-range) - Integrated policy validation into signature verification (v2 and v4) - Validates policy conditions against actual POST request data - Added serde_json dependency to s3s crate Co-authored-by: Nugine <[email protected]>
- Fixed doc comment formatting (use backticks instead of quotes) - Removed unused self parameters from static methods - Fixed format string inlining warnings in tests - Fixed needless borrow warnings Co-authored-by: Nugine <[email protected]>
- Increased ops::call limit from 1600 to 1650 bytes - Increased S3Service::call limit from 3000 to 3050 bytes - Increased S3Service::call_owned limit from 3300 to 3350 bytes - These increases are due to the added Option<PostPolicy> field Co-authored-by: Nugine <[email protected]>
- Return EntityTooSmall when file_size < min - Return EntityTooLarge when file_size > max - Previously always returned EntityTooSmall for both cases Co-authored-by: Nugine <[email protected]>
Copilot
AI
changed the title
[WIP] Add e2e tests for checking POST policy support
Add POST Policy validation for browser-based S3 uploads
Dec 8, 2025
Collaborator
|
- Merged origin/main into copilot/add-e2e-tests-for-post-policy - Removed unused import of s3_error macro (already available via #[macro_use]) - All tests and clippy checks passing Co-authored-by: Nugine <[email protected]>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST Policy E2E Tests and Bug Fixes
Completed Tasks:
Summary:
Added comprehensive POST Policy validation to s3s:
{"field": "value"}or["eq", "$field", "value"])["starts-with", "$field", "prefix"])["content-length-range", min, max])The implementation validates policies against actual request data, preventing unauthorized uploads that don't match policy constraints.
Recent Updates:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.