Merged
Conversation
Previously, there was a bug that potentially caused non-termination of the algorithm. If there was a loop that did not include the starting node, and the `min_score` was sufficiently low, the algorithm could return an arbitrarily large number of paths going round and round that loop. While these paths are technically valid matches, they are not really constructive, in a sense that they do repeat the nodes that they match, just with different weights. Furthermore, it is necessary from a technical point of view to avoid them so that the algorithm terminates. This adds an additional check that the current path does not run into such a loop, as well as the corresponding unittest to check that it works as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there was a bug that potentially caused non-termination of the algorithm. If there was a loop that did not include the starting node, and the
min_scorewas sufficiently low, the algorithm could return an arbitrarily large number of paths going round and round that loop.While these paths are technically valid matches, they are not really constructive, in a sense that they do repeat the nodes that they match, just with different weights. Furthermore, it is necessary from a technical point of view to avoid them so that the algorithm terminates.
This adds an additional check that the current path does not run into such a loop, as well as the corresponding unittest to check that it works as intended.