Optimise SVG plots, bump SVG line widths#188
Open
ewels wants to merge 1 commit intos-andrews:masterfrom
Open
Conversation
Reduce SVG file sizes by: - Moving font-family to a CSS <style> block instead of per-element attributes - Using fill/stroke attributes instead of verbose style="..." syntax - Merging consecutive same-colour <line> segments into <polyline> elements - Run-length merging adjacent same-colour <rect> elements (benefits tile heatmap) - Increasing line stroke-width to 2 for better visibility SVG generation changes are in SVGGenerator.java (attribute format). Post-processing optimisations are in SVGImageSaver.java (polyline/rect merging). PNG rendering is unaffected as it uses Java2D directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimised the SVG plot outputs, reducing total SVG file size by 73% with no visual changes.
This is fairly meaningless by itself, but in the future I would love for the HTML reports to embed SVGs instead of PNGs. Then the file size of the SVGs suddenly does matter, as they're all embedded and we don't want massive HTML files.
The main improvement is for per-tile sequence quality, but there are improvements on all SVGs. Example on a 27M-read FASTQ file (ERR16944282):
adapter_content.svgduplication_levels.svgper_base_n_content.svgper_base_quality.svgper_base_sequence_content.svgper_sequence_gc_content.svgper_sequence_quality.svgper_tile_quality.svgsequence_length_distribution.svgChanges 🤖
AI summary of changes:
Shorter attributes (
SVGGenerator.java)font-family="Arial"from every<text>element to a single<style>block in the SVG headerstyle="fill:rgb(...);stroke:none"withfill="rgb(...)"style="fill:none;stroke-width:1;stroke:rgb(...)"withfill="none" stroke="rgb(...)"Element merging (
SVGImageSaver.java)Post-processing applied to the SVG string before writing to disk:
<line>segments (data series) are merged into a single<polyline>withstroke-width="2"for better visibility. Gridlines and axis lines (black/grey) are left as individual<line>elements withstroke-width="1".<rect>elements on the same row are merged into a single wider rect. This primarily benefits the per-tile quality heatmap, which draws thousands of small rectangles.What's not affected
Graphics2D, which doesn't go throughSVGGeneratorfastqc_data.txt,summary.txt) is unchangedThe only visual change is the thicker lines for line plots, which matches what the PNGs look like:
69 KB57 KB31 KB9 KB405 KB60 KB