Trim trailing rows from Adapter Content when --min_length is used#187
Open
ewels wants to merge 3 commits intos-andrews:masterfrom
Open
Trim trailing rows from Adapter Content when --min_length is used#187ewels wants to merge 3 commits intos-andrews:masterfrom
--min_length is used#187ewels wants to merge 3 commits intos-andrews:masterfrom
Conversation
… used When --min_length inflates the X-axis beyond the actual adapter position data, the Adapter Content module produced trailing rows of all zeros. These positions have no adapter data (adapter positions only extend to sequence_length - adapter_length + 1) so the extra rows add no information. Trim them after computing enrichments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Regenerate approved output to reflect the adapter content trailing-zero trimming and the current 0.12.2.devel version string. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The previous approach trimmed all trailing all-zero rows, which incorrectly removed legitimate zero-data positions when no adapters were found. Now only trim when --min_length actually inflated the X-axis beyond the real adapter position data, and trim to the exact boundary of real data. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--min_lengthinflates the X-axis beyond the actual adapter position data, the Adapter Content module produced trailing rows of all zeros.These positions have no adapter data (adapter positions only extend to
sequence_length - adapter_length + 1) so the extra rows add no information.This PR trims them after computing enrichments.