Skip to content

Fixes and Improvements to useHasNewDeploy Hook #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igorroc wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes and Improvements to useHasNewDeploy Hook #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d349f23
fix: Updated interval logic to use `>` instead of `<` for `loopInterval`
igorroc Jun 20, 2024
95ba6a5
fix: Response status when there is error
igorroc Jun 20, 2024
f1bc172
fix: Weird console log
igorroc Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/next-deploy-notifications/src/hooks/use-has-new-deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import useWindowFocus from "use-window-focus";

let getCurrentVersion = async (endpoint: string) => {
let response = await fetch(endpoint);
if (response.status > 400) {
if (response.status >= 400) {
console.error(
"[next-deploy-notifications] Could not find current app version. Did you setup the API route?"
);
Expand All @@ -31,7 +31,7 @@ type UseHasNewDeploy = (options?: HookOptions) => HookValues;
let useHasNewDeploy: UseHasNewDeploy = (options = {}) => {
let debug = (message: string) => {
if (options.debug) {
console.log(...["[Deploy notifications] ", message]);
console.log("[Deploy notifications] ", message);
}
};

Expand All @@ -44,7 +44,7 @@ let useHasNewDeploy: UseHasNewDeploy = (options = {}) => {
let endpoint = options.endpoint ?? "/api/has-new-deploy";
let isUnknown = currentVersion === "unknown";

let loopInterval = interval < 3_000 ? interval : 3_000;
let loopInterval = interval > 3_000 ? interval : 3_000;
let loopOrNotInterval = !hasNewDeploy && windowFocused ? loopInterval : null;

useInterval(async () => {
Expand Down