fix: the download failed after uploading an SVG icon #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly for fix #42 .
When I upload my own svg icon and click download button,the button remains in the loading state and the download fails with an error:
This error is mainly because dom-to-image cannot handle when dom contains svg img, here is the detail dom-to-image/issues/266.
dom-to-image-more can solve the problem.
But when I use dom-to-image-more, the downloaded image has a border:
I’m not completely certain about the original intention behind adding a border to the CoverImage. However, to ensure the stability of the existing logic, I decided to use a trick: add the class name to the DOM before generating the image, and remove it after generating the image.
The main code is
element.classList.add("export-mode")andelement.classList.remove("export-mode")Try again
Success!