Skip to content

chore(lint): remove old prettier adapter#50

Open
jlizen wants to merge 1 commit into
rustsec:masterfrom
jlizen:fix/eslint-prettier-config
Open

chore(lint): remove old prettier adapter#50
jlizen wants to merge 1 commit into
rustsec:masterfrom
jlizen:fix/eslint-prettier-config

Conversation

@jlizen

@jlizen jlizen commented Jun 9, 2026

Copy link
Copy Markdown

Fix for:

npm run lint


Error: Cannot read config file:
  node_modules/eslint-config-prettier/@typescript-eslint.js

Error: "prettier/@typescript-eslint" has been merged into "prettier"
  in eslint-config-prettier 8.0.0.

This does add a bunch of lint failures once it runs. I could fix it in a different PR if you want.

@djc

djc commented Jun 9, 2026

Copy link
Copy Markdown
Member

This does add a bunch of lint failures once it runs. I could fix it in a different PR if you want.

Would like to have those in the same commit (so that each commit could ideally pass CI).

@jlizen

jlizen commented Jun 9, 2026

Copy link
Copy Markdown
Author

Sure, it will have pretty deep tendrils, but I can lump the cleanup pass in here.

@jlizen

jlizen commented Jun 9, 2026

Copy link
Copy Markdown
Author

It looks like CI currently is passing... it might be that I am on a newer toolchain locally or something (or a lint step is not being called). I'll take a look and see if there is a cleanup pass needed on the CI as well.

@djc

djc commented Jun 9, 2026

Copy link
Copy Markdown
Member

Looks like npm run lint is currently commented out in the CI workflow... probably something to fix, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants