Skip to content

Add advisory for timing variability in curve25519-dalek-ng #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fspreiss
Copy link

The timing variability in curve25519-dalek that was reported via RUSTSEC-2024-0344 is also applicable to its fork curve25519-dalek-ng.

This is relevant because crates such as ed255519-consensus, which are actively used by the community for secret key operations, depend on the vulnerable curve25519-dalek-ng.

@fspreiss fspreiss marked this pull request as ready for review June 27, 2025 22:21
@djc
Copy link
Contributor

djc commented Jun 28, 2025

As a matter of policy, we don't publish advisories without confirmation/agreement from the maintainer, unless the maintainer becomes unresponsive (for 270 days in case of no open issues or 60 days in case of a potential vulnerability).

@hdevalence are you aware of this issue? Do you agree it warrants an advisory?

@hdevalence
Copy link

hdevalence commented Jun 28, 2025

I don't think this issue warrants an advisory, but I don't think it's particularly important either way. It should be fixed shortly, just fell through the cracks and there was no follow up.

@djc
Copy link
Contributor

djc commented Jun 28, 2025

I don't think this issue warrants an advisory,

Why not? If the pre-fork code had one, it seems surprising that this crate wouldn't get one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants