-
Notifications
You must be signed in to change notification settings - Fork 89
lib: derive Debug
on StartHandshake
#120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I also wanted to enable the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not that convinced. These aren't long-lived types nor are the debug values seemingly going to be especially meaningful.
@djc that's a fair point. |
I'd be okay reviewing another iteration that only adds |
This auto-derives a `Debug` implementation for `StartHandshake`.
Debug
on public typesDebug
on StartHandshake
Thanks for the feedback! I took the occasion to also add a docstring (and some breadcrumbs) on that type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This auto-derives a
Debug
implementation forStartHandshake
.