Add interactive string interop example with ownership and user flow - #40
Conversation
|
Hi, I've already looked at your PR #30, we're just going to focus on one PR per person for now. After that PR is finished, we can decide what to do with this one. |
teor2345
left a comment
There was a problem hiding this comment.
This is a good example, but let's shorten or remove the documentation file, and name it README.md
| @@ -0,0 +1,153 @@ | |||
| - Problem Name: string-interop-interact | |||
There was a problem hiding this comment.
This file isn't a problem statement, it is a description of the example.
We don't need something this long to describe an example, please summarise what the example does. It is also ok to delete this file and just write a short README.md
|
You'll also have to resolve conflicts, I think rebasing or squashing the PR should do it. |
shashu8660
left a comment
There was a problem hiding this comment.
updated the readme.md
teor2345
left a comment
There was a problem hiding this comment.
Thank you! Let's merge if it passes CI.
The merge-base changed after approval.
Please squash the PR. Some commits contain files in the examples/rust-cpp-basic-interop directory, which already exists in the main branch. Those commits will disappear when you squash. I can help with this if you need it? |
|
I done it , do I need to do any other changes |
|
Looks like maybe you accidentally deleted a bunch of changes you just made, rather than squashing them? The code and docs you had in the previous commits were fine, we just need to combine all the commits into a single commit. |
748a407 to
a849604
Compare
|
Is there anything else do I need to change or any update ? |
|
When you tried to squash, you deleted some files from other examples, and reversed some changes in your previous commits. Don't do that. Instead, go back to your previous branch, and squash the commits together using |
address review feedback Restore rust-cpp-basic-interop example
|
Thank you for pointing out the mistake I was making @teor2345 , |
teor2345
left a comment
There was a problem hiding this comment.
Thanks!
I've deleted the .gitignore file because there's already one in the repository base directory.
Let's merge!
It's just a redundant file deletion, so I'm going to override this and merge, |
This PR adds an interactive string interoperability example between Rust and C++.
The example demonstrates:
The example includes:
This aligns with the string interop problem https://github.com/rustfoundation/interop-initiative/blob/main/problem-space/0002-string-interop.md & demonstrates safe handling of string ownership and memory across language boundaries