ip-link: Adds support for veth, bond and bridge interface types#6
ip-link: Adds support for veth, bond and bridge interface types#6yonatan-linik wants to merge 4 commits intorust-netlink:mainfrom
Conversation
|
I see the tests failed because of one of the timers changing between the 2 commands running. |
07d63cb to
96e404c
Compare
|
I do not have time for cleaning this up. I am blindly accepting contributions for now. Will clean up in my weekend (sorry, not my business project). sudo is OK. Please rebase to last which has bridge covered somehow. |
|
For the CI test cases, please us similar stuff like https://github.com/nispor/nispor/blob/base/src/lib/integ_tests/veth.rs#L26 To me this And next time, be cautious on introducing new dependency. |
96e404c to
fcc28a5
Compare
Setup for tests is now part of the Makefile.
fcc28a5 to
3a63935
Compare
|
@cathay4t No rush, but it is ready for review/merge |
|
@cathay4t Can we move forward with this PR? I would like to implement other parts of the command but I don't want a tower of unmerged branches. |
No description provided.