Implement arithmetic operation traits for x86 SIMD types #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @folkertdev rustbot has assigned @folkertdev. Use |
|
CI is stuck on #1897 🤦🏽 |
|
yeah that will likely take a couple of days at least |
bjorn3
reviewed
Aug 8, 2025
| macro_rules! impl_arith_op { | ||
| (__internal $op:ident, $intrinsic:ident $_:ident) => { | ||
| #[inline] | ||
| fn $op(self, rhs: Self) -> Self { |
There was a problem hiding this comment.
These are missing a #[target_feature(enable = "...")] matching the _mm* caller, so the MIR inliner will not inline them and LLVM may not inline them either.
There was a problem hiding this comment.
simd_* intrinsics call the platform-independent LLVM intrinsics/instructions. The conversion to ASM checks the available feature flags, and uses them as available. See rust-lang/libs-team#628 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#628
Tracking Issue: rust-lang/rust#145066
Unresolved questions: Should we have
NotandRemimplementations? At leastNotseems quite useful.I will send the PRs of other archs after this is merged, as they also use the common macro