Forbid tail calling intrinsics #144851
Merged
Forbid tail calling intrinsics #144851
+44
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Aug 3, 2025
Comment on lines
108
to
109
| ty::Instance::try_resolve(self.tcx, self.typing_env, did, args) | ||
| && let InstanceKind::Intrinsic(_) = instance.def |
There was a problem hiding this comment.
importing InstanceKind but not Instance is a bit weird 🤔
|
r=me unless you want a specific review |
WaffleLapkin
force-pushed
the
instrinsic-deny
branch
from
3454cee to
38a1b07
Compare
scottmcm
reviewed
Aug 3, 2025
Comment on lines
107
to
109
| if let Ok(Some(instance)) = | ||
| ty::Instance::try_resolve(self.tcx, self.typing_env, did, args) | ||
| && let ty::InstanceKind::Intrinsic(_) = instance.def |
There was a problem hiding this comment.
Do you need the resolve here? Can probably just do https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/context/struct.TyCtxt.html#method.intrinsic.is_some()?
(Since you never get to an intrinsic through a trait impl or whatever.)
There was a problem hiding this comment.
Doh, I somehow completely missed that c-e already said this 🤦
scottmcm
approved these changes
Aug 3, 2025
WaffleLapkin
force-pushed
the
instrinsic-deny
branch
from
38a1b07 to
c539890
Compare
|
@bors r=compiler-errors,scottmcm rollup |
bors
added
S-waiting-on-bors
21 tasks
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Aug 3, 2025
…mpiler-errors,scottmcm Forbid tail calling intrinsics There is only one intrinsic that can be called on stable, as far as I can find, (`transmute`). And in general tail calling intrinsics doesn't make much sense. Alternative to rust-lang#144815 (and thus closes rust-lang#144815) Fixes rust-lang#144806 r? `@scottmcm`
This was referenced Aug 3, 2025
bors
added a commit
that referenced
this pull request
Aug 3, 2025
Rollup of 12 pull requests Successful merges: - #142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - #144070 (Implement `hash_map` macro ) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144790 (Multiple bounds checking elision failures) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) - #144843 (Weekly `cargo update`) - #144851 (Forbid tail calling intrinsics) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 4, 2025
Rollup merge of #144851 - WaffleLapkin:instrinsic-deny, r=compiler-errors,scottmcm Forbid tail calling intrinsics There is only one intrinsic that can be called on stable, as far as I can find, (`transmute`). And in general tail calling intrinsics doesn't make much sense. Alternative to #144815 (and thus closes #144815) Fixes #144806 r? ``@scottmcm``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only one intrinsic that can be called on stable, as far as I can find, (
transmute). And in general tail calling intrinsics doesn't make much sense.Alternative to #144815 (and thus closes #144815)
Fixes #144806
r? @scottmcm