Constify trait aliases #144291
Open
Constify trait aliases #144291
+275
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt HIR ty lowering was modified cc @fmease Changes to the size of AST and/or HIR nodes. cc @nnethercote Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
nnethercote
reviewed
Jul 22, 2025
| static_assert_size!(Item, 144); | ||
| static_assert_size!(ItemKind, 80); | ||
| static_assert_size!(Item, 136); | ||
| static_assert_size!(ItemKind, 72); |
|
Clippy changes are approved. |
ytmimi
reviewed
Jul 22, 2025
src/tools/rustfmt/src/visitor.rs
Outdated
There was a problem hiding this comment.
Can we add a simple test case for #![feature(trait_alias, const_trait_impl)] in src/tools/rustfmt/tests/target. Would be nice to make sure rustfmt isn't formatting the code incorrectly.
|
☔ The latest upstream changes (presumably #143897) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
force-pushed
the
const_trait_alias
branch
2 times, most recently
from
cb809b6 to
7508ac9
Compare
|
☔ The latest upstream changes (presumably #143843) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
force-pushed
the
const_trait_alias
branch
from
7508ac9 to
5d3eb69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
const trait Foo = Bar + [const] Baz;trait alias declarations. Their rules are the same as with super traits of const traits. So[const] Bazorconst Bazis only required for[const] Fooorconst Foobounds respectively.tracking issue #41517 (part of the general trait alias feature gate, but I can split it out into a separate const trait alias feature gate. I just assumed that const traits would stabilize before trait aliases, and we'd want to stabilize trait aliases together with const trait aliases at the same time)
r? @compiler-errors @fee1-dead