Skip to content

Add opaque TypeId handles for CTFE #143696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Add opaque TypeId handles for CTFE #143696

merged 2 commits into from
Jul 10, 2025
+432 −151

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 9, 2025

Reopen of #142789 (comment) after some bors insta-merge chaos

r? @RalfJung

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 9, 2025

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 9, 2025

@bors r=RalfJung rollup=iffy

@bors
Copy link
Collaborator

bors commented Jul 9, 2025

📌 Commit 5108471 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2025
antoyo
antoyo reviewed Jul 9, 2025
View reviewed changes
compiler/rustc_codegen_gcc/src/common.rs
GlobalAlloc::TypeId { .. } => {
let val = self.const_usize(offset.bytes());
// This is still a variable of pointer type, even though we only use the provenance
// of that pointer in CTFE and Miri. But to make LLVM's type system happy,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// of that pointer in CTFE and Miri. But to make LLVM's type system happy,
// of that pointer in CTFE and Miri. But to make GCC's type system happy,

?

@bors
Copy link
Collaborator

bors commented Jul 10, 2025

⌛ Testing commit 5108471 with merge cf3fb76...

@bors
Copy link
Collaborator

bors commented Jul 10, 2025

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing cf3fb76 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 10, 2025
@bors bors merged commit cf3fb76 into rust-lang:master Jul 10, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 32cd911 (parent) -> cf3fb76 (this PR)

Test differences

Show 21 test diffs

Stage 1

  • [ui] tests/ui/consts/const_transmute_type_id.rs: [missing] -> pass (J1)
  • [ui] tests/ui/consts/const_transmute_type_id2.rs: [missing] -> pass (J1)
  • [ui] tests/ui/consts/const_transmute_type_id3.rs: [missing] -> pass (J1)
  • [ui] tests/ui/consts/const_transmute_type_id4.rs: [missing] -> pass (J1)

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) -> pass (J0)
  • [ui] tests/ui/consts/const_transmute_type_id.rs: [missing] -> pass (J2)
  • [ui] tests/ui/consts/const_transmute_type_id2.rs: [missing] -> pass (J2)
  • [ui] tests/ui/consts/const_transmute_type_id3.rs: [missing] -> pass (J2)
  • [ui] tests/ui/consts/const_transmute_type_id4.rs: [missing] -> pass (J2)

Additionally, 12 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cf3fb768db439825e3c8d327f6d9f46e02965668 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 4154.3s -> 7030.0s (69.2%)
  2. x86_64-apple-1: 8880.1s -> 6142.7s (-30.8%)
  3. pr-check-1: 2358.2s -> 1751.6s (-25.7%)
  4. x86_64-rust-for-linux: 3929.4s -> 2984.8s (-24.0%)
  5. x86_64-gnu-tools: 4726.1s -> 3708.5s (-21.5%)
  6. dist-x86_64-apple: 9722.4s -> 7798.8s (-19.8%)
  7. aarch64-apple: 5690.4s -> 4631.6s (-18.6%)
  8. test-various: 5716.1s -> 4687.6s (-18.0%)
  9. x86_64-gnu-nopt: 8874.0s -> 7340.3s (-17.3%)
  10. x86_64-gnu-miri: 5978.1s -> 5011.6s (-16.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@oli-obk oli-obk deleted the constable-type-id2 branch July 10, 2025 10:15
@oli-obk oli-obk mentioned this pull request Jul 10, 2025
Open
4 tasks
@bors bors mentioned this pull request Jul 10, 2025
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cf3fb76): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)		 0.2% [0.1%, 0.2%] 6
Improvements ✅
(primary)		 -0.2% [-0.3%, -0.1%] 20
Improvements ✅
(secondary)		 -0.3% [-0.6%, -0.1%] 37
All ❌✅ (primary) -0.1% [-0.3%, 0.4%] 21

Max RSS (memory usage)

Results (primary -1.1%, secondary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.9% [1.1%, 3.1%] 4
Regressions ❌
(secondary)		 3.7% [3.7%, 3.7%] 1
Improvements ✅
(primary)		 -5.2% [-8.2%, -1.9%] 3
Improvements ✅
(secondary)		 -3.7% [-7.0%, -1.3%] 9
All ❌✅ (primary) -1.1% [-8.2%, 3.1%] 7

Cycles

Results (primary 3.4%, secondary 5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)		 5.0% [5.0%, 5.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.4% [3.4%, 3.4%] 1

Binary size

Results (primary 0.1%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.2% [0.0%, 1.3%] 12
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 2
Improvements ✅
(primary)		 -0.1% [-0.5%, -0.0%] 10
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [-0.5%, 1.3%] 22

Bootstrap: 465.513s -> 463.762s (-0.38%)
Artifact size: 374.51 MiB -> 374.55 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoyo antoyo antoyo left review comments

Assignees

@RalfJung RalfJung

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rustbot @bors @rust-timer @antoyo @RalfJung