-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Port #[link_ordinal] to the new attribute parsing infrastructure #143217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
☔ The latest upstream changes (presumably #143233) made this pull request unmergeable. Please resolve the merge conflicts. |
38ee95d
to
b85d685
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #143556) made this pull request unmergeable. Please resolve the merge conflicts. |
84cdff7
to
929b899
Compare
This comment has been minimized.
This comment has been minimized.
Port #[link_ordinal] to the new attribute parsing infrastructure
6c7538d
to
d92419f
Compare
Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_data_structures |
Ports link_ordinal to the new attribute parsing infrastructure for #131229 (comment) r? @oli-obk |
This is a windows-only attribute. I ran the ui test suite on Windows 11, but maybe a try run is in order? Up to you @oli-obk |
Lemme see if I can do that: (probably not?) |
@JonathanBrouwer: 🔑 Insufficient privileges: not in try users |
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
Port #[link_ordinal] to the new attribute parsing infrastructure Ports link_ordinal to the new attribute parsing infrastructure for #131229 (comment) try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
@@ -29,6 +29,7 @@ impl AttributeKind { | |||
Ignore { .. } => No, | |||
Inline(..) => No, | |||
LinkName { .. } => Yes, | |||
LinkOrdinal { .. } => Yes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find where this was previously encoded cross crate. Isn't it simply part of codegen_fn_attrs and otherwise we don't need to store the attribute itself?
Ports link_ordinal to the new attribute parsing infrastructure for #131229 (comment)