"set by Rusts options"

[nabijaczleweli]

No description provided.

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[nabijaczleweli]

Also am I crazy or is this example nonsensical?

use std::fs::OpenOptions;
use std::os::unix::fs::OpenOptionsExt;

let mut options = OpenOptions::new();
options.write(true);
if cfg!(unix) {
    options.custom_flags(libc::O_NOFOLLOW);
}
let file = options.open("foo.txt");

You'd want this to be #[cfg(unix)] use std::os::unix::fs::OpenOptionsExt; and #[cfg(unix)] options.custom_flags(libc::O_NOFOLLOW); right?

[bjorn3]

The example is already on a trait that is #[cfg(unix)]. And just adding #[cfg(unix)] would potentially introduce a symlink vulnerability on non-unic systems.

[nabijaczleweli]

Under that analysis, what's the if cfg!(unix) doing there, since that's guaranteed to be true?

[bjorn3]

Right. When that example is tested, it is always true.