Skip to content

Port #[must_use] to new attribute parsing infrastructure #142780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Port #[must_use] to new attribute parsing infrastructure #142780

merged 1 commit into from
Jun 22, 2025
+151 −69

Conversation

JonathanBrouwer
Copy link
Contributor

Ports must_use to the new attribute parsing infrastructure for #131229 (comment)

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

JonathanBrouwer
JonathanBrouwer commented Jun 20, 2025
View reviewed changes
compiler/rustc_passes/src/check_attr.rs
@@ -686,7 +688,8 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
Attribute::Parsed(
AttributeKind::Deprecation { .. }
| AttributeKind::Repr { .. }
| AttributeKind::Align { .. },
| AttributeKind::Align { .. }
| AttributeKind::MustUse { .. },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added MustUse here but not removed it from the ALLOW_LIST above, because you also seem to not have done this for the other attributes. Is this correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just rewritten the naked attribute, so this shouldn't be necessary anymore. but dw, I'll do the rebase on there

@jdonszelmann jdonszelmann mentioned this pull request Jun 20, 2025
Open
9 tasks
@JonathanBrouwer
Copy link
Contributor Author

Rebased to solve merge conflicts

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2025

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

  • It's intentional.
  • The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

@rustbot rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Jun 20, 2025
@JonathanBrouwer JonathanBrouwer force-pushed the must_use_new_attr branch 2 times, most recently from b17cbe2 to f549f43 Compare June 20, 2025 21:03
@bors
Copy link
Collaborator

bors commented Jun 21, 2025

☔ The latest upstream changes (presumably #142794) made this pull request unmergeable. Please resolve the merge conflicts.

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Jun 21, 2025 •
edited
Loading

Rebased to solve merge conflicts

@JonathanBrouwer JonathanBrouwer force-pushed the must_use_new_attr branch 3 times, most recently from f031214 to eeb53ac Compare June 21, 2025 13:33
@JonathanBrouwer
Copy link
Contributor Author

Rebased to solve merge conflicts

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 21, 2025

☔ The latest upstream changes (presumably #142826) made this pull request unmergeable. Please resolve the merge conflicts.

@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit 11d9029 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@GrigorenkoPV
Copy link
Contributor

The commit message is wrong

@JonathanBrouwer
Copy link
Contributor Author

Woops sorry, fixed! Working on a few too many PRs at the same time :P

@JonathanBrouwer
Copy link
Contributor Author

Rebased to solve merge conflicts

@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit b24df42 has been approved by jdonszelmann

It is now in the queue for this repository.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 22, 2025
Merged
bors added a commit that referenced this pull request Jun 22, 2025
@bors
Auto merge of #142878 - GuillaumeGomez:rollup-53dohob, r=GuillaumeGomez
111e9bc 
Rollup of 10 pull requests

Successful merges:

 - #142458 (Merge unboxed trait object error suggestion into regular dyn incompat error)
 - #142593 (Add a warning to LateContext::get_def_path)
 - #142594 (Add DesugaringKind::FormatLiteral)
 - #142740 (Clean-up `FnCtxt::is_destruct_assignment_desugaring`)
 - #142780 (Port `#[must_use]` to new attribute parsing infrastructure)
 - #142798 (Don't fail to parse a struct if a semicolon is used to separate fields)
 - #142856 (Add a few inline directives in rustc_serialize.)
 - #142868 (remove few allow(dead_code))
 - #142874 (cranelift: fix target feature name typo: "fxsr")
 - #142877 (Document why tidy checks if `eslint` is installed via `npm`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2681bb0 into rust-lang:master Jun 22, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 22, 2025
rust-timer added a commit that referenced this pull request Jun 22, 2025
@rust-timer
Unrolled build for #142780
db86f3f 
Rollup merge of #142780 - JonathanBrouwer:must_use_new_attr, r=jdonszelmann

Port `#[must_use]` to new attribute parsing infrastructure

Ports `must_use` to the new attribute parsing infrastructure for #131229 (comment)

r? `@jdonszelmann`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonszelmann jdonszelmann jdonszelmann left review comments

Assignees

@jdonszelmann jdonszelmann

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
6 participants
@JonathanBrouwer @rustbot @rust-log-analyzer @bors @jdonszelmann @GrigorenkoPV