Inline drops in MIR #142583

cjgillot · 2025-06-16T16:27:07Z

cjgillot · 2025-06-16T16:28:59Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-16T16:29:03Z

⌛ Trying commit b76e9cb with merge 8fae7b1…

To cancel the try build, run the command @bors2 try cancel.

Inline drops in MIR r? `@ghost`

rust-log-analyzer · 2025-06-16T17:05:02Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tests/pass/float_nan.rs ... ok
tests/pass/0weak_memory_consistency_sc.rs ... ok

FAILED TEST: tests/pass/async-drop.rs (revision `stack`)
command: MIRI_ENV_VAR_TEST="0" MIRI_TEMP="/tmp/miri-uitest-jVmU4h" RUST_BACKTRACE="1" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/miri" "--error-format=json" "--sysroot=/checkout/obj/build/x86_64-unknown-linux-gnu/miri-sysroot" "-Dwarnings" "-Dunused" "-Ainternal_features" "-O" "-Zmir-opt-level=4" "-Cdebug-assertions=yes" "-Zui-testing" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/tmp/miri_ui/0/tests/pass" "tests/pass/async-drop.rs" "-Zmiri-strict-provenance" "--edition" "2021" "--cfg=stack" "-Cextra-filename=stack"

error: test got exit status: 101, but expected 0
 = note: the compiler panicked

full stderr:
warning: Miri does not support optimizations: the opt-level is ignored. The only effect of selecting a Cargo profile that enables optimizations (such as --release) is to apply its remaining settings, such as whether debug assertions and overflow checks are enabled.

warning: You have explicitly enabled MIR optimizations, overriding Miri's default which is to completely disable them. Any optimizations may hide UB that Miri would otherwise detect, and it is not necessarily possible to predict what kind of UB will be missed. If you are enabling optimizations to make Miri run faster, we advise using cfg(miri) to shrink your workload instead. The performance benefit of enabling MIR optimizations is usually marginal at best.


thread 'rustc' panicked at compiler/rustc_mir_transform/src/inline.rs:813:73:
DefId::expect_local: `DefId(2:15419 ~ core[5850]::future::async_drop::async_drop_in_place::{closure#0})` isn't local
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: rustc_mir_transform::inline::process_blocks::<rustc_mir_transform::inline::NormalInliner>
   3: <rustc_mir_transform::inline::NormalInliner as rustc_mir_transform::inline::Inliner>::on_inline_success
   4: rustc_mir_transform::inline::process_blocks::<rustc_mir_transform::inline::NormalInliner>
   5: <rustc_mir_transform::inline::Inline as rustc_mir_transform::pass_manager::MirPass>::run_pass
   6: rustc_mir_transform::pass_manager::run_passes_inner
   7: rustc_mir_transform::run_optimization_passes
   8: rustc_mir_transform::shim::make_shim
      [... omitted 2 frames ...]
   9: <rustc_middle::ty::context::TyCtxt>::instance_mir
  10: <rustc_const_eval::interpret::eval_context::InterpCx<miri::machine::MiriMachine>>::load_mir
  11: <rustc_const_eval::interpret::eval_context::InterpCx<miri::machine::MiriMachine>>::init_fn_call
  12: <rustc_const_eval::interpret::eval_context::InterpCx<miri::machine::MiriMachine> as miri::concurrency::thread::EvalContextExt>::run_threads
  13: miri::eval::eval_entry
  14: <miri::MiriCompilerCalls as rustc_driver_impl::Callbacks>::after_analysis
  15: <std::thread::local::LocalKey<core::cell::Cell<*const ()>>>::with::<rustc_middle::ty::context::tls::enter_context<<rustc_middle::ty::context::GlobalCtxt>::enter<rustc_interface::passes::create_and_enter_global_ctxt<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}, core::option::Option<rustc_interface::queries::Linker>>::{closure#1}, core::option::Option<rustc_interface::queries::Linker>>::{closure#0}, core::option::Option<rustc_interface::queries::Linker>>
  16: <rustc_middle::ty::context::TyCtxt>::create_global_ctxt::<core::option::Option<rustc_interface::queries::Linker>, rustc_interface::passes::create_and_enter_global_ctxt<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}>
  17: <rustc_interface::passes::create_and_enter_global_ctxt<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>::{closure#2} as core::ops::function::FnOnce<(&rustc_session::session::Session, rustc_middle::ty::context::CurrentGcx, alloc::sync::Arc<rustc_data_structures::jobserver::Proxy>, &std::sync::once_lock::OnceLock<rustc_middle::ty::context::GlobalCtxt>, &rustc_data_structures::sync::worker_local::WorkerLocal<rustc_middle::arena::Arena>, &rustc_data_structures::sync::worker_local::WorkerLocal<rustc_hir::Arena>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2})>>::call_once::{shim:vtable#0}
  18: <alloc::boxed::Box<dyn for<'a> core::ops::function::FnOnce<(&'a rustc_session::session::Session, rustc_middle::ty::context::CurrentGcx, alloc::sync::Arc<rustc_data_structures::jobserver::Proxy>, &'a std::sync::once_lock::OnceLock<rustc_middle::ty::context::GlobalCtxt<'a>>, &'a rustc_data_structures::sync::worker_local::WorkerLocal<rustc_middle::arena::Arena<'a>>, &'a rustc_data_structures::sync::worker_local::WorkerLocal<rustc_hir::Arena<'a>>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}), Output = core::option::Option<rustc_interface::queries::Linker>>> as core::ops::function::FnOnce<(&rustc_session::session::Session, rustc_middle::ty::context::CurrentGcx, alloc::sync::Arc<rustc_data_structures::jobserver::Proxy>, &std::sync::once_lock::OnceLock<rustc_middle::ty::context::GlobalCtxt>, &rustc_data_structures::sync::worker_local::WorkerLocal<rustc_middle::arena::Arena>, &rustc_data_structures::sync::worker_local::WorkerLocal<rustc_hir::Arena>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2})>>::call_once
  19: rustc_interface::passes::create_and_enter_global_ctxt::<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>
  20: <scoped_tls::ScopedKey<rustc_span::SessionGlobals>>::set::<rustc_interface::util::run_in_thread_with_globals<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<(), rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}::{closure#0}, ()>
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

error: the compiler unexpectedly panicked. this is a bug.
---

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [mir_shims] generating MIR shim for `core::future::async_drop::async_drop_in_place::{closure#0}`, instance=FutureDropPollShim(DefId(2:15419 ~ core[5850]::future::async_drop::async_drop_in_place::{closure#0}), Coroutine(DefId(2:15419 ~ core[5850]::future::async_drop::async_drop_in_place::{closure#0}), [Coroutine(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt, (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt]), (AsyncInt,)]), (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(2:15419 ~ core[5850]::future::async_drop::async_drop_in_place::{closure#0}), [Coroutine(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt, (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt]), (AsyncInt,)])]), (*mut Coroutine(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt, (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt]), (AsyncInt,)]),)]), Coroutine(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt, (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt]), (AsyncInt,)]))
end of query stack

Miri caused an ICE during evaluation. Here's the interpreter backtrace at the time of the panic:
note: the place in the program where the ICE was triggered
  --> tests/pass/async-drop.rs:41:20
   |
LL |       let fut = pin!(async {
   |  ____________________^
LL | |         test_async_drop(Int(0)).await;
LL | |         test_async_drop(AsyncInt(0)).await;
LL | |         test_async_drop([AsyncInt(1), AsyncInt(2)]).await;
...  |
LL | |         test_async_drop(AsyncUnion { signed: 21 }).await;
LL | |     });
   | |_____^
   |
   = note: BACKTRACE:
   = note: inside closure at tests/pass/async-drop.rs:41:20: 86:6
note: inside `main`
  --> tests/pass/async-drop.rs:87:15
   |
LL |     let res = fut.poll(&mut cx);
   |               ^^^^^^^^^^^^^^^^^
   = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /checkout/library/core/src/ops/function.rs:250:5: 250:71
   = note: inside `std::sys::backtrace::__rust_begin_short_backtrace::<fn(), ()>` at /checkout/library/std/src/sys/backtrace.rs:152:18: 152:21
   = note: inside closure at /checkout/library/std/src/rt.rs:206:18: 206:75
   = note: inside `std::ops::function::impls::<impl std::ops::FnOnce<()> for &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>::call_once` at /checkout/library/core/src/ops/function.rs:284:13: 284:31
   = note: inside `std::panicking::catch_unwind::do_call::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /checkout/library/std/src/panicking.rs:589:40: 589:43
   = note: inside `std::panicking::catch_unwind::<i32, &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>` at /checkout/library/std/src/panicking.rs:552:19: 552:88
   = note: inside `std::panic::catch_unwind::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /checkout/library/std/src/panic.rs:359:14: 359:40
   = note: inside closure at /checkout/library/std/src/rt.rs:175:24: 175:49
   = note: inside `std::panicking::catch_unwind::do_call::<{closure@std::rt::lang_start_internal::{closure#0}}, isize>` at /checkout/library/std/src/panicking.rs:589:40: 589:43
   = note: inside `std::panicking::catch_unwind::<isize, {closure@std::rt::lang_start_internal::{closure#0}}>` at /checkout/library/std/src/panicking.rs:552:19: 552:88
   = note: inside `std::panic::catch_unwind::<{closure@std::rt::lang_start_internal::{closure#0}}, isize>` at /checkout/library/std/src/panic.rs:359:14: 359:40
   = note: inside `std::rt::lang_start_internal` at /checkout/library/std/src/rt.rs:171:5: 193:7
   = note: inside `std::rt::lang_start::<()>` at /checkout/library/std/src/rt.rs:205:5: 210:6

warning: 2 warnings emitted


full stdout:
AsyncInt::async_drop: 0



FAILED TEST: tests/pass/async-drop.rs (revision `tree`)
command: MIRI_ENV_VAR_TEST="0" MIRI_TEMP="/tmp/miri-uitest-jVmU4h" RUST_BACKTRACE="1" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/miri" "--error-format=json" "--sysroot=/checkout/obj/build/x86_64-unknown-linux-gnu/miri-sysroot" "-Dwarnings" "-Dunused" "-Ainternal_features" "-O" "-Zmir-opt-level=4" "-Cdebug-assertions=yes" "-Zui-testing" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/tmp/miri_ui/0/tests/pass" "tests/pass/async-drop.rs" "-Zmiri-strict-provenance" "-Zmiri-tree-borrows" "--edition" "2021" "--cfg=tree" "-Cextra-filename=tree"

error: test got exit status: 101, but expected 0
 = note: the compiler panicked

full stderr:
warning: Miri does not support optimizations: the opt-level is ignored. The only effect of selecting a Cargo profile that enables optimizations (such as --release) is to apply its remaining settings, such as whether debug assertions and overflow checks are enabled.

warning: You have explicitly enabled MIR optimizations, overriding Miri's default which is to completely disable them. Any optimizations may hide UB that Miri would otherwise detect, and it is not necessarily possible to predict what kind of UB will be missed. If you are enabling optimizations to make Miri run faster, we advise using cfg(miri) to shrink your workload instead. The performance benefit of enabling MIR optimizations is usually marginal at best.


thread 'rustc' panicked at compiler/rustc_mir_transform/src/inline.rs:813:73:
DefId::expect_local: `DefId(2:15419 ~ core[5850]::future::async_drop::async_drop_in_place::{closure#0})` isn't local
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: rustc_mir_transform::inline::process_blocks::<rustc_mir_transform::inline::NormalInliner>
   3: <rustc_mir_transform::inline::NormalInliner as rustc_mir_transform::inline::Inliner>::on_inline_success
   4: rustc_mir_transform::inline::process_blocks::<rustc_mir_transform::inline::NormalInliner>
   5: <rustc_mir_transform::inline::Inline as rustc_mir_transform::pass_manager::MirPass>::run_pass
   6: rustc_mir_transform::pass_manager::run_passes_inner
   7: rustc_mir_transform::run_optimization_passes
   8: rustc_mir_transform::shim::make_shim
      [... omitted 2 frames ...]
   9: <rustc_middle::ty::context::TyCtxt>::instance_mir
  10: <rustc_const_eval::interpret::eval_context::InterpCx<miri::machine::MiriMachine>>::load_mir
  11: <rustc_const_eval::interpret::eval_context::InterpCx<miri::machine::MiriMachine>>::init_fn_call
  12: <rustc_const_eval::interpret::eval_context::InterpCx<miri::machine::MiriMachine> as miri::concurrency::thread::EvalContextExt>::run_threads
  13: miri::eval::eval_entry
  14: <miri::MiriCompilerCalls as rustc_driver_impl::Callbacks>::after_analysis
  15: <std::thread::local::LocalKey<core::cell::Cell<*const ()>>>::with::<rustc_middle::ty::context::tls::enter_context<<rustc_middle::ty::context::GlobalCtxt>::enter<rustc_interface::passes::create_and_enter_global_ctxt<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}, core::option::Option<rustc_interface::queries::Linker>>::{closure#1}, core::option::Option<rustc_interface::queries::Linker>>::{closure#0}, core::option::Option<rustc_interface::queries::Linker>>
  16: <rustc_middle::ty::context::TyCtxt>::create_global_ctxt::<core::option::Option<rustc_interface::queries::Linker>, rustc_interface::passes::create_and_enter_global_ctxt<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}>
  17: <rustc_interface::passes::create_and_enter_global_ctxt<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>::{closure#2} as core::ops::function::FnOnce<(&rustc_session::session::Session, rustc_middle::ty::context::CurrentGcx, alloc::sync::Arc<rustc_data_structures::jobserver::Proxy>, &std::sync::once_lock::OnceLock<rustc_middle::ty::context::GlobalCtxt>, &rustc_data_structures::sync::worker_local::WorkerLocal<rustc_middle::arena::Arena>, &rustc_data_structures::sync::worker_local::WorkerLocal<rustc_hir::Arena>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2})>>::call_once::{shim:vtable#0}
  18: <alloc::boxed::Box<dyn for<'a> core::ops::function::FnOnce<(&'a rustc_session::session::Session, rustc_middle::ty::context::CurrentGcx, alloc::sync::Arc<rustc_data_structures::jobserver::Proxy>, &'a std::sync::once_lock::OnceLock<rustc_middle::ty::context::GlobalCtxt<'a>>, &'a rustc_data_structures::sync::worker_local::WorkerLocal<rustc_middle::arena::Arena<'a>>, &'a rustc_data_structures::sync::worker_local::WorkerLocal<rustc_hir::Arena<'a>>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}), Output = core::option::Option<rustc_interface::queries::Linker>>> as core::ops::function::FnOnce<(&rustc_session::session::Session, rustc_middle::ty::context::CurrentGcx, alloc::sync::Arc<rustc_data_structures::jobserver::Proxy>, &std::sync::once_lock::OnceLock<rustc_middle::ty::context::GlobalCtxt>, &rustc_data_structures::sync::worker_local::WorkerLocal<rustc_middle::arena::Arena>, &rustc_data_structures::sync::worker_local::WorkerLocal<rustc_hir::Arena>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2})>>::call_once
  19: rustc_interface::passes::create_and_enter_global_ctxt::<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>
  20: <scoped_tls::ScopedKey<rustc_span::SessionGlobals>>::set::<rustc_interface::util::run_in_thread_with_globals<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<(), rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}::{closure#0}, ()>
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

error: the compiler unexpectedly panicked. this is a bug.
---

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [mir_shims] generating MIR shim for `core::future::async_drop::async_drop_in_place::{closure#0}`, instance=FutureDropPollShim(DefId(2:15419 ~ core[5850]::future::async_drop::async_drop_in_place::{closure#0}), Coroutine(DefId(2:15419 ~ core[5850]::future::async_drop::async_drop_in_place::{closure#0}), [Coroutine(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt, (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt]), (AsyncInt,)]), (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(2:15419 ~ core[5850]::future::async_drop::async_drop_in_place::{closure#0}), [Coroutine(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt, (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt]), (AsyncInt,)])]), (*mut Coroutine(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt, (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt]), (AsyncInt,)]),)]), Coroutine(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt, (), core::future::ResumeTy, (), (), CoroutineWitness(DefId(0:21 ~ async_drop[65ff]::test_async_drop::{closure#0}), [AsyncInt]), (AsyncInt,)]))
end of query stack

Miri caused an ICE during evaluation. Here's the interpreter backtrace at the time of the panic:
note: the place in the program where the ICE was triggered
  --> tests/pass/async-drop.rs:41:20
   |
LL |       let fut = pin!(async {
   |  ____________________^
LL | |         test_async_drop(Int(0)).await;
LL | |         test_async_drop(AsyncInt(0)).await;
LL | |         test_async_drop([AsyncInt(1), AsyncInt(2)]).await;
...  |
LL | |         test_async_drop(AsyncUnion { signed: 21 }).await;
LL | |     });
   | |_____^
   |
   = note: BACKTRACE:
   = note: inside closure at tests/pass/async-drop.rs:41:20: 86:6
note: inside `main`
  --> tests/pass/async-drop.rs:87:15
   |
LL |     let res = fut.poll(&mut cx);
   |               ^^^^^^^^^^^^^^^^^
   = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /checkout/library/core/src/ops/function.rs:250:5: 250:71
   = note: inside `std::sys::backtrace::__rust_begin_short_backtrace::<fn(), ()>` at /checkout/library/std/src/sys/backtrace.rs:152:18: 152:21
   = note: inside closure at /checkout/library/std/src/rt.rs:206:18: 206:75
   = note: inside `std::ops::function::impls::<impl std::ops::FnOnce<()> for &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>::call_once` at /checkout/library/core/src/ops/function.rs:284:13: 284:31
   = note: inside `std::panicking::catch_unwind::do_call::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /checkout/library/std/src/panicking.rs:589:40: 589:43
   = note: inside `std::panicking::catch_unwind::<i32, &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>` at /checkout/library/std/src/panicking.rs:552:19: 552:88
   = note: inside `std::panic::catch_unwind::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /checkout/library/std/src/panic.rs:359:14: 359:40
   = note: inside closure at /checkout/library/std/src/rt.rs:175:24: 175:49
   = note: inside `std::panicking::catch_unwind::do_call::<{closure@std::rt::lang_start_internal::{closure#0}}, isize>` at /checkout/library/std/src/panicking.rs:589:40: 589:43
   = note: inside `std::panicking::catch_unwind::<isize, {closure@std::rt::lang_start_internal::{closure#0}}>` at /checkout/library/std/src/panicking.rs:552:19: 552:88
   = note: inside `std::panic::catch_unwind::<{closure@std::rt::lang_start_internal::{closure#0}}, isize>` at /checkout/library/std/src/panic.rs:359:14: 359:40
   = note: inside `std::rt::lang_start_internal` at /checkout/library/std/src/rt.rs:171:5: 193:7
   = note: inside `std::rt::lang_start::<()>` at /checkout/library/std/src/rt.rs:205:5: 210:6

warning: 2 warnings emitted

---

Location:
   /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ui_test-0.29.2/src/lib.rs:369

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
error: test failed, to rerun pass `--test ui`

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/ui-3ca614ea6d3a8322 tests/pass tests/panic` (exit status: 1)
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:05:40
  local time: Mon Jun 16 17:04:51 UTC 2025
  network time: Mon, 16 Jun 2025 17:04:51 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

rust-bors · 2025-06-16T18:55:57Z

☀️ Try build successful (CI)
Build commit: 8fae7b1 (8fae7b12efec27fba07277a1e4b7637e45fe6298, parent: d9ca9bd014074e2bac567eaa2b66bfacb2591028)

rust-timer · 2025-06-16T23:30:04Z

Finished benchmarking commit (8fae7b1): comparison URL.

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

nalgebra-0.33.0
nalgebra-0.33.0-new-solver
eza-0.21.2

❗ ❗ ❗ ❗ ❗

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.2%, 3.8%]	46
Regressions ❌ (secondary)	1.4%	[0.1%, 5.5%]	37
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	6
Improvements ✅ (secondary)	-0.6%	[-1.5%, -0.2%]	14
All ❌✅ (primary)	0.6%	[-0.3%, 3.8%]	52

Max RSS (memory usage)

Results (primary 1.8%, secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[0.9%, 6.5%]	21
Regressions ❌ (secondary)	3.2%	[1.5%, 9.4%]	8
Improvements ✅ (primary)	-3.9%	[-5.4%, -2.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.8%	[-5.4%, 6.5%]	23

Cycles

Results (primary 1.7%, secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.7%, 4.0%]	12
Regressions ❌ (secondary)	2.8%	[1.0%, 6.1%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.7%	[0.7%, 4.0%]	12

Binary size

Results (primary 0.2%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.0%, 5.6%]	65
Regressions ❌ (secondary)	1.1%	[0.0%, 5.6%]	19
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.0%]	10
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	41
All ❌✅ (primary)	0.2%	[-0.2%, 5.6%]	75

Bootstrap: 756.489s -> 762.44s (0.79%)
Artifact size: 372.07 MiB -> 372.25 MiB (0.05%)

cjgillot added 3 commits June 16, 2025 15:54

Fortify RemoveUnneededDrops test.

9485afb

Allow inlining drops.

fce390d

Add fast path for trivial drops.

b76e9cb

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 16, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 16, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Inline drops in MIR #142583

Inline drops in MIR #142583

Uh oh!

cjgillot commented Jun 16, 2025

Uh oh!

cjgillot commented Jun 16, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 16, 2025

Uh oh!

rust-log-analyzer commented Jun 16, 2025

Uh oh!

rust-bors bot commented Jun 16, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 16, 2025

Uh oh!

Uh oh!

Inline drops in MIR #142583

Are you sure you want to change the base?

Inline drops in MIR #142583

Uh oh!

Conversation

cjgillot commented Jun 16, 2025

Uh oh!

cjgillot commented Jun 16, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 16, 2025

Uh oh!

rust-log-analyzer commented Jun 16, 2025

Uh oh!

rust-bors bot commented Jun 16, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 16, 2025

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!