Don't fold in Instantiate when there's nothing to fold #142317
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Jun 10, 2025
Don't fold in Instantiate when there's nothing to fold Maybe this helps idk r? lcnr
rustbot
added
the
S-waiting-on-perf
|
i feel like ive tested this before lol |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (4b9e637): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 755.415s -> 754.049s (-0.18%) |
rustbot
added
perf-regression
|
I think the perf wins outweigh the perf hits. @rustbot ready |
compiler-errors
commented
Jun 12, 2025
compiler/rustc_type_ir/src/binder.rs
Outdated
| @@ -622,6 +622,10 @@ impl<I: Interner, T: TypeFoldable<I>> ty::EarlyBinder<I, T> { | |||
| where | |||
| A: SliceLike<Item = I::GenericArg>, | |||
| { | |||
| // Nothing to fold. | |||
| if !cfg!(debug_assertions) && args.is_empty() { | |||
There was a problem hiding this comment.
We still fold if cfg!(debug_assertions) since the arg folder can detect out of bound arg instantiations, and that's useful in debug builds.
I believe that this is morally a debug assertion, since we never expect it in practice.
There was a problem hiding this comment.
instead of still folding with debug assertions, check whether the value has params.
r=me after this nit
compiler-errors
force-pushed
the
perf-fold
branch
from
cbd67db to
2b52d65
Compare
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 14, 2025
Don't fold in Instantiate when there's nothing to fold Maybe this helps idk r? lcnr
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this helps idk
r? lcnr