Repository navigation
Tracking issue for migrating from Glacier to compiletest ICE/crash tracking #125459
Description
Tracks the necessary steps to "fully"1 transition from rust-lang/glacier to compiletest ICE/crash tracking inside tests/crashes/.
See also this Zulip topic.
Steps
- Implement
rustcICE/crash tracking: compiletest ice tracking #122997 - Implement
rustdocICE/crash tracking -
Implement(questionable)rustfmtICE/crash tracking - Implement ICE/crash tracking via
run-make/rmake(to supersede Glacier's shell scripts) - Archive rust-lang/glacier: 🧊 Put glacier on ice 🧊 team#1459
- Sunset triagebot support for Glacier
- Update the rustc-dev-guide: Flesh out sections about crashes tests and update mentions of glacier rustc-dev-guide#2413
- Remove mentions of Glacier
- Add small section about
tests/crashes/: Overview, rough procedure (adding//@ known-bug, S-bug-has-testStatus: This bug is tracked inside the repo by a `known-bug` test. ) - Rename "crashes tests" to "crash tests" rustc-dev-guide#2588
- Mention
tests/crashes/in places where we reference E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added. (EDIT(fmease): What did I mean by this?)
- Update the Rust Forge
- Remove mentions of Glacier (namely the triagebot section): Remove mention of now removed
triagebotglacierintegration rust-forge#856 - Maybe mention the new system in the issue triaging chapter (EDIT(fmease): The Forge, really?)
- Remove mentions of Glacier (namely the triagebot section): Remove mention of now removed
- If technically feasible, add a CI check that a PR fixing crash tests mentions all fixed issues via GH auto-close keywords like Fixes to prevent the accumulation of "ghost issues". EDIT(fmease): triagebot nowadays posts a general message if
tests/crashes/has been modified. Doesn't that suffice?
Unresolved Questions
- Should we implement
rustdocsupport via subdirectories/tests suites (e.g.,tests/crashes/rustdoc/) or via a new compiletest directive (e.g.,//@ bin: rustdoc)- If we do the former, should we move
rustctests fromtests/crashes/totests/crashes/rustc/?
- If we do the former, should we move
- Should we define precise procedures for adding new tests to
tests/crashes?
Footnotes
-
Glacier|_{rust-lang/rust}, i.e., restriction of Glacier to rust-lang/rust (excluding git submodules/subtrees), i.e., Glacier without support for rustfmt, Cargo, Clippy, Miri ICE/crash tracking ↩
Activity
fmease commentedon May 23, 2024
cc @matthiaskrgr
[-]Tracking issue for migrating from Glacier to compiletest ICE tracking[/-][+]Tracking issue for migrating from Glacier to compiletest ICE/crash tracking[/+]matthiaskrgr commentedon May 23, 2024
I'm not sure if it makes a lot of sense to track crashes inside the rustc repo for tools (rustfmt, clippy, miri etc) that are actually living inside their own repos because in most cases I guess you would "accidentally" fix something during a submodule/tree sync?
fmease commentedon May 23, 2024
Good point. I guess that means T-rustfmt/T-cargo/... for example will need to introduce their own mechanism assuming they're interested in doing that and that "we" won't try to find a Glacier replacement for them now that it's officially archived.
Rollup merge of rust-lang#141427 - fmease:dis-triagebot-glacier, r=Urgau
Rollup merge of rust-lang#141427 - fmease:dis-triagebot-glacier, r=Urgau
Rollup merge of rust-lang#141427 - fmease:dis-triagebot-glacier, r=Urgau
Unrolled build for #141427
Rollup merge of #141427 - fmease:dis-triagebot-glacier, r=Urgau