-
Notifications
You must be signed in to change notification settings - Fork 204
Fix tests by adding markdown tags #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if they help with better codeblock hinting (or avoiding trying to use Rust syntax highlighting for non-Rust snippets), it seems fine
So maybe the question is, are we interested in fixing these tests? Are we using tests here anyway?
Note that AFAIK none of these are tests, and are only codeblocks for stylistic/illustrative reasons.
(BTW, what does |
MDbook uses Highlight.js and it seems to be just an alias for
|
Yes, that's also my understanding (i.e. cosmetic linting) |
Alright, the changes in this PR seems fine in that case. Just wanted to note that I don't think we're running |
073d63a
to
73ed15f
Compare
73ed15f
to
7bd597c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I noticed that we have a command
mdbook test
, I have run it and discovered a massive quantity of linting errors.I did a random visual check and adding the
console
parameter to all these quoted texts does not seems to change anything but fixes the tests.So maybe the question is, are we interested in fixing these tests? Are we using tests here anyway?
thanks for sharing an opinion :)
Note: I left out from this patch some lints failures because they involve Rust code and I suspect it's just not linting
Rendered