Show where the book was generated #2729
Open
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
reviewed
Jul 14, 2025
| @@ -482,6 +482,8 @@ impl Renderer for HtmlHandlebars { | |||
| // Copy all remaining files, avoid a recursive copy from/to the book build dir | |||
| utils::fs::copy_files_except_ext(&src_dir, destination, true, Some(&build_dir), &["md"])?; | |||
|
|
|||
| info!("Book has been generated into `{}`", build_dir.display()); | |||
There was a problem hiding this comment.
Was there a particular reason to use build_dir instead of destination? It might be confusing, since this is specifically for the HTML renderer, but this is showing the root output directory which might not be where the HTML output actually resides. Maybe something like this?
Suggested change
| info!("Book has been generated into `{}`", build_dir.display()); | |
| info!("HTML book written to `{}`", destination.display()); |
There was a problem hiding this comment.
No particular reason, simply missed that HTML output folder might not be the same as build folder.
GuillaumeGomez
force-pushed
the
info-log-location
branch
from
05b2136 to
f48ad42
Compare
GuillaumeGomez
force-pushed
the
info-log-location
branch
from
f48ad42 to
aa0ce35
Compare
|
Updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now looks like this:
It's very convenient to see where the book is actually generated (even more when working on mdbook 😆).