-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(index): Stabilize pubtime #16372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
|
|
||
| ## pubtime | ||
|
|
||
| The `pubtime` index field has been stabilized in Rust 1.94.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this set for 1.94
|
@rfcbot fcp merge T-cargo |
|
Team member @epage has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge is blocked on T-crates.io informing us that they have made a decision
| "rust_version": "1.60", | ||
| // The publish time for the package (optional). | ||
| // | ||
| // In ISO8601 with UTC timezone (e.g. 2025-11-12T19:30:12Z) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make the description a bit more unambiguous enough for custom registry to implement?
Perhaps follows what we put in cargo generate-lockfile "yyyy-mm-ddThh:mm:ssZ".
| // In ISO8601 with UTC timezone (e.g. 2025-11-12T19:30:12Z) | |
| // In ISO8601 with UTC timezone (yyyy-mm-ddThh:mm:ssZ). | |
| // Fractional seconds and offsets are not allowed. | |
| // | |
| // Example: 2025-11-12T19:30:12Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It now enumerates the subset of ISO8601
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ![]()
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
What does this PR try to resolve?
Unblocks #15973, #5221
Closes #15491
Closes #16270
How to test and review this PR?