refactor(lint): move lints to separate modules #16364

weihanglo · 2025-12-08T23:57:17Z

What does this PR try to resolve?

Instead of putting everything in a single module,
this moves stuff to their own file for better logic isolation.

How to test and review this PR?

rustbot · 2025-12-08T23:57:22Z

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

weihanglo · 2025-12-09T00:01:02Z

src/cargo/util/lints/unknown_lints.rs

+    ),
+};
+
+pub fn output_unknown_lints(


unknown_lints is weird that it analyzes only at package level, and warn if your lint is inherited from workspace. According to the discussion in #16321 (comment), we should probably lint against workspace always plus selected packages.

Actually, the entire analyze_cargo_lints_table should be move into this module.

Back to only move output_unknown_lints. We can refactor analyze_cargo_lints_table in next PRs. See #16364 (comment).

src/cargo/util/lints/unknown_lints.rs

epage · 2025-12-09T13:58:03Z

r? @Muscraft

weihanglo · 2025-12-09T16:01:03Z

Windows MSVC

https://github.com/rust-lang/cargo/actions/runs/20069081791/job/57565703379

---- cache_lock::mutate_then_download stdout ----

thread 'cache_lock::mutate_then_download' (10132) panicked at tests\testsuite\cache_lock.rs:15:5:
test did not finish within 10 attempts (1.0022125s total)


failures:
    cache_lock::mutate_then_download

test result: FAILED. 3612 passed; 1 failed; 367 ignored; 0 measured; 0 filtered out; finished in 1087.91s

Muscraft

Moving things to separate modules makes a ton of sense in the long run. I am a bit concerned about changing the const names to all be LINT but it is fine for now and is and easy to switch if needed in the future.

View changes since this review

Update cargo submodule 27 commits in 2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac..c46423de7351e3c4c734b2faa86088a9f5d1302b 2025-12-04 16:47:28 +0000 to 2025-12-12 23:16:12 +0000 - feat(report): cargo report timings HTML replay (rust-lang/cargo#16377) - feat: stabilize `-Zconfig-include` (rust-lang/cargo#16284) - fix(package): Don't verify registry for --list (rust-lang/cargo#16341) - Fixed incorrect locking logic when artifact-dir == build-dir (rust-lang/cargo#16385) - feat(log): make timing messages ready for HTML replay (rust-lang/cargo#16382) - chore(deps): update msrv (1 version) to v1.92 (rust-lang/cargo#16381) - Downgrade curl-sys to 0.4.83 (rust-lang/cargo#16379) - fix(timing): more self-contained timing/log data (rust-lang/cargo#16378) - test: update to `proc_macro::tracked::path` (rust-lang/cargo#16380) - refactor(lint): move lints to separate modules (rust-lang/cargo#16364) - fix(index): Apply feedback from Cargo team (rust-lang/cargo#16369) - fix(lints): handle lints separately at ws pkg level (rust-lang/cargo#16367) - feat(lint): new `implicit_minimum_version_req` lint (rust-lang/cargo#16321) - fix(info): default to local without explicit reg (rust-lang/cargo#16358) - Remove `[no-mentions]` handler in our triagebot config (rust-lang/cargo#16361) - Don't read the config file twice when $CARGO_HOME is a symlink (rust-lang/cargo#16325) - fix(timings): forgot to negate filter (rust-lang/cargo#16352) - fix(doctest): Include all search paths with new build layout (rust-lang/cargo#16348) - fix(layout): Remove hashes from bins in new layout (rust-lang/cargo#16351) - docs(faq): Include an entry on disk space (rust-lang/cargo#16349) - feat(timings): derive concurrency data from unit data (rust-lang/cargo#16350) - perf(layout): Use unit_id, not pkg hash, for bin/lib pkg_dirs for new layout (rust-lang/cargo#16345) - Validate target source paths before compilation with clearer errors (rust-lang/cargo#16338) - test(doc): Remove unused build script (rust-lang/cargo#16344) - refactor(timings): store UnitData in RenderContext instead (rust-lang/cargo#16346) - perf(clean): Optimize (legacy) clean with multiple -p specifiers (rust-lang/cargo#16264) - test: Adjust output for out-of-tree build-dir (rust-lang/cargo#16343)

Update cargo submodule 29 commits in 2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac..e91b2baa632c0c7e84216c91ecfe107c37d887c1 2025-12-04 16:47:28 +0000 to 2025-12-13 16:29:21 +0000 - refactor(lints): move from cargo::util::lints to cargo::lints (rust-lang/cargo#16392) - test(lint): redact more due to line got omitted (rust-lang/cargo#16391) - feat(report): cargo report timings HTML replay (rust-lang/cargo#16377) - feat: stabilize `-Zconfig-include` (rust-lang/cargo#16284) - fix(package): Don't verify registry for --list (rust-lang/cargo#16341) - Fixed incorrect locking logic when artifact-dir == build-dir (rust-lang/cargo#16385) - feat(log): make timing messages ready for HTML replay (rust-lang/cargo#16382) - chore(deps): update msrv (1 version) to v1.92 (rust-lang/cargo#16381) - Downgrade curl-sys to 0.4.83 (rust-lang/cargo#16379) - fix(timing): more self-contained timing/log data (rust-lang/cargo#16378) - test: update to `proc_macro::tracked::path` (rust-lang/cargo#16380) - refactor(lint): move lints to separate modules (rust-lang/cargo#16364) - fix(index): Apply feedback from Cargo team (rust-lang/cargo#16369) - fix(lints): handle lints separately at ws pkg level (rust-lang/cargo#16367) - feat(lint): new `implicit_minimum_version_req` lint (rust-lang/cargo#16321) - fix(info): default to local without explicit reg (rust-lang/cargo#16358) - Remove `[no-mentions]` handler in our triagebot config (rust-lang/cargo#16361) - Don't read the config file twice when $CARGO_HOME is a symlink (rust-lang/cargo#16325) - fix(timings): forgot to negate filter (rust-lang/cargo#16352) - fix(doctest): Include all search paths with new build layout (rust-lang/cargo#16348) - fix(layout): Remove hashes from bins in new layout (rust-lang/cargo#16351) - docs(faq): Include an entry on disk space (rust-lang/cargo#16349) - feat(timings): derive concurrency data from unit data (rust-lang/cargo#16350) - perf(layout): Use unit_id, not pkg hash, for bin/lib pkg_dirs for new layout (rust-lang/cargo#16345) - Validate target source paths before compilation with clearer errors (rust-lang/cargo#16338) - test(doc): Remove unused build script (rust-lang/cargo#16344) - refactor(timings): store UnitData in RenderContext instead (rust-lang/cargo#16346) - perf(clean): Optimize (legacy) clean with multiple -p specifiers (rust-lang/cargo#16264) - test: Adjust output for out-of-tree build-dir (rust-lang/cargo#16343)

rustbot assigned ehuss Dec 8, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 8, 2025

weihanglo commented Dec 9, 2025

View reviewed changes

weihanglo force-pushed the lint-refactor branch from 851abd8 to 05b1d92 Compare December 9, 2025 00:11

weihanglo commented Dec 9, 2025

View reviewed changes

src/cargo/util/lints/unknown_lints.rs Outdated Show resolved Hide resolved

weihanglo marked this pull request as draft December 9, 2025 00:34

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Dec 9, 2025

rustbot assigned Muscraft and unassigned ehuss Dec 9, 2025

weihanglo added 5 commits December 9, 2025 09:10

refactor(lint): move blanket_hints_mostly_used to a module

808086a

refactor(lint): move im_a_teapot to a module

465e9a3

refactor(lint): move unknown_lints to a module

16c2dcb

refactor(lint): rename const to LINT

5cb6887

test(lint): ensure lints in their own modules

4e39141

weihanglo force-pushed the lint-refactor branch from 05b1d92 to 4e39141 Compare December 9, 2025 15:33

weihanglo marked this pull request as ready for review December 9, 2025 16:02

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2025

weihanglo added A-new-lint Area: new lint and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. A-new-lint Area: new lint labels Dec 9, 2025

weihanglo mentioned this pull request Dec 9, 2025

fix(index): Apply feedback from Cargo team #16369

Merged

Muscraft approved these changes Dec 10, 2025

View reviewed changes

Muscraft added this pull request to the merge queue Dec 10, 2025

Merged via the queue into rust-lang:master with commit 983e027 Dec 10, 2025
51 of 56 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 10, 2025

weihanglo mentioned this pull request Dec 12, 2025

Update cargo submodule rust-lang/rust#149934

Merged

weihanglo mentioned this pull request Dec 13, 2025

fix(lint): dont embed lint docs in cargo binary #16360

Closed

rustbot added this to the 1.94.0 milestone Dec 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(lint): move lints to separate modules #16364

refactor(lint): move lints to separate modules #16364

weihanglo commented Dec 8, 2025

Uh oh!

rustbot commented Dec 8, 2025

Uh oh!

weihanglo Dec 9, 2025

Uh oh!

weihanglo Dec 9, 2025

Uh oh!

weihanglo Dec 9, 2025

Uh oh!

Uh oh!

This comment has been minimized.

epage commented Dec 9, 2025

Uh oh!

weihanglo commented Dec 9, 2025

Uh oh!

Muscraft left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

refactor(lint): move lints to separate modules #16364

refactor(lint): move lints to separate modules #16364

Conversation

weihanglo commented Dec 8, 2025

What does this PR try to resolve?

How to test and review this PR?

Uh oh!

rustbot commented Dec 8, 2025

Uh oh!

weihanglo Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

weihanglo Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

weihanglo Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

epage commented Dec 9, 2025

Uh oh!

weihanglo commented Dec 9, 2025

Uh oh!

Muscraft left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Muscraft left a comment •

edited by rustbot

Loading