Skip to content

test(msrv): use a far future "newer" version #15693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jun 22, 2025

Two tests were using .rust_version("1.90.0") for a "newer" Rust, but
this failed in rust-lang/rust#142792 for the start of the real 1.90.0.
Let's bump that to 1.999.0 so we won't have to deal with it for a while.

Two tests were using `.rust_version("1.90.0")` for a "newer" Rust, but
this failed in rust-lang/rust#142792 for the start of the *real* 1.90.0.
Let's bump that to 1.999.0 so we won't have to deal with it for a while.
@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2025
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not 100% positive why it was done the way that it was, but this seems like it should fix the issue. I'll post a submodule update.

@ehuss ehuss added this pull request to the merge queue Jun 22, 2025
@ehuss
Copy link
Contributor

ehuss commented Jun 22, 2025

Hm, I would like to also get #15696 merged before the beta branch (otherwise we would need to immediately beta backport it). Would it be ok to wait until tomorrow (or whenever someone gets back online)?

@cuviper
Copy link
Member Author

cuviper commented Jun 22, 2025

Sure, I think it's ok if the 1.89/1.90 branching slips a little bit.

Merged via the queue into rust-lang:master with commit 4832e11 Jun 22, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants