fix!: Panic if Patch span is beyond the end of buffer #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
approved these changes
Jul 3, 2025
Muscraft
force-pushed
the
sugg-span-beyond-buffer
branch
from
32ca293 to
83d2cbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given a patch span beyond the end of the source, we silently allow it to work. Conversely, when we are given an annotation span beyond the end of the source, we panic. This PR makes it so that we consistently panic when given spans beyond the end of a source.
Note: This PR is only meant to make
annotate-snippetsbehave consistently and does not intend to delve into what the correct response should be.