Skip to content

Give a name to the migrations example (#382) #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kriswuollett
Copy link
Contributor

No description provided.

@jxs jxs closed this Jul 25, 2025
@jxs
Copy link
Member

jxs commented Jul 25, 2025

pull request is stale, going to close

@kriswuollett
Copy link
Contributor Author

kriswuollett commented Jul 26, 2025

Why is the pull request stale? There is a linked issue for it that could be evaluated: closes #382.

@jxs
Copy link
Member

jxs commented Jul 26, 2025

cause it introduces no changes, sorry. Do you want to update it?
ah I see now that it's just renaming the main.rs, but you also need add it in the Cargo.toml as a binary

@jxs jxs reopened this Jul 26, 2025
@kriswuollett
Copy link
Contributor Author

cause it introduces no changes, sorry. Do you want to update it? ah I see now that it's just renaming the main.rs, but you also need add it in the Cargo.toml as a binary

You wish it to be added for documentation reasons? The package.autobins should be defaulting to true, so listing a named binary file in the manifest should be unnecessary unless customization is needed:

% cargo run --bin refinery-examples-migrate

...

warning: `refinery-core` (lib) generated 5 warnings (run `cargo fix --lib -p refinery-core` to apply 4 suggestions)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/refinery-examples-migrate`

@kriswuollett kriswuollett force-pushed the refactor-named-examples branch from 60ec2ce to 454e339 Compare July 27, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants