chore: Update htslib to 1.23#32
Conversation
seems like this does nothing, cf. https://docs.rs/cc/1.2.56/cc/struct.Build.html#method.static_flag
it's nice one, the first to support 2021 edition. Could probably go older but I just wanted to make it explicit
shows up on https://lib.rs/crates/hts-sys/features for example
htslib 1.23 merged hfile_s3_write.c into hfile_s3.c
dlejeune
left a comment
dlejeune
left a comment
There was a problem hiding this comment.
Looks good to me, and checked that it does indeed compile on my machine (famous last words lol).
Hopefully this can get merged!
| cp target/debug/build/hts-sys-*/out/bindings.rs osx_prebuilt_bindings.rs | ||
| ``` | ||
|
|
||
| ### Linux |
There was a problem hiding this comment.
I assume that the need for docker is cause you're on a Mac -- might be worth just noting that here?
| } | ||
|
|
||
| cfg.file("wrapper.c"); | ||
| cfg.cargo_warnings(false); |
There was a problem hiding this comment.
Not super familiar with this, but don't we want to leave cargo warnings on?
There was a problem hiding this comment.
I always like having more docs :)
One thing that tripped me up initially is needing to clone this repo recursively, and then also doing git pull --recurse-submodules otherwise you get weird compiler errors. So maybe we can add that to the documentation?
|
Hey -- @johanneskoester are there any chances of this getting merged in? I had a cursory look at this PR and all seems good in my book. |
2 participants
Bump the hts submodule to version 1.23 (see https://github.com/samtools/htslib/releases/tag/1.23) and also update the prebuilt bindings.
Along the way, I also change a bunch of other things, e.g. making the minimum Rust version explicit and removing the static feature as
ccalways sets this now.