Skip to content

Conversation

@bbyalcinkaya
Copy link
Member

Replaces top_down with bottom_up to avoid redundant traversals in replacement terms, improving performance for large terms. While replacement terms are usually not large, this change enables an optimization in komet that results in a 3x speedup.

The optimization in komet works by embedding large configuration cells without variables directly into a replacement term. This prevents the substitution algorithm from needlessly traversing these large terms, significantly reducing overhead.

@rv-jenkins rv-jenkins changed the base branch from master to develop March 13, 2025 15:41
@bbyalcinkaya bbyalcinkaya marked this pull request as ready for review March 13, 2025 22:56
@bbyalcinkaya bbyalcinkaya requested a review from gtrepta March 13, 2025 22:56
Copy link
Contributor

@gtrepta gtrepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch. I recall picking top_down over bottom_up for performance reasons, I don't remember how I decided that and admittedly didn't test it.

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 4113224 into develop Mar 14, 2025
18 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the burak/fuzz-subst-bottom-up branch March 14, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants