HOTFIX free after simplify bool, call munmap after each request #4115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
commented
Jul 2, 2025
| @@ -154,11 +159,24 @@ void kore_symbol_add_formal_argument(kore_symbol *, kore_sort const *); | |||
|
|
|||
| void kllvm_init(void); | |||
| void kllvm_free_all_memory(void); | |||
| void reset_munmap_all_arenas(void); | |||
There was a problem hiding this comment.
This is the important function, the rest is just aligning the header file contents with the upstream version.
jberthold
commented
Jul 2, 2025
tothtamas28
approved these changes
Jul 2, 2025
|
Going to merge this as-is and adjust to the released API later when the llvm-backend build/release has gone through CI successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem that surfaced in the
kontrolupgrade (symptom: server crashes unexpectedly after some iterations).The LLVM backend was changed to not call
munmapwithinfree_all_kore_memany more, which makes themmapcalls to initialise thread-local heap address space fail after a number of requests.This is a hot-fix which calls
reset_munmap_all_arenas, a function not currently included in the LLVM backend C API.The function will be included in the API once runtimeverification/llvm-backend#1210 is merged, then the header file and the function name should be aligned with the API again.
The backend is not going to work with older LLVM backends because the function that needs to be called is new as of June 7.