Add --smt-arg to kore
#4025
Merged
Add --smt-arg to kore
#4025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
approved these changes
Aug 12, 2024
jberthold
approved these changes
Aug 12, 2024
| , SMT.rLimit = rLimit | ||
| , SMT.resetInterval = resetInterval | ||
| , SMT.prelude = prelude | ||
| , SMT.arguments = args <> SMT.Config.arguments SMT.defaultConfig |
There was a problem hiding this comment.
Maybe we should only use the default if the args are empty? This would enable users to get rid of defaults that we may set in the future.
Suggested change
| , SMT.arguments = args <> SMT.Config.arguments SMT.defaultConfig | |
| , SMT.arguments = if null args then SMT.Config.arguments SMT.defaultConfig else args |
There was a problem hiding this comment.
The default options contain -smt2 -in command which is necessary I think.
There was a problem hiding this comment.
True, we certainly need the -in option in any way
(BTW smtlib-backends does not use the -smt2 option)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4024