fix lora and multi-lora #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandyamarut
approved these changes
Mar 26, 2025
|
Can this be merged? Hotfixing my containers to hack lora support is a pain |
|
+1 for merge |
|
Had a similar problem, ended up forking and patching with this commit (which seems to be working great!) My fork and the associated container in case its helpful to anyone: https://github.com/kirkbyo/worker-vllm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #127 and #130 prs by @sven-knoblauch I have fixed the lora (currently bugged as stated in #162 issue) and multi lora support.
In addition, I have updated the README.md with the LORA_MODULES env var.