fix: pass Docker tag variables as env vars instead of build args#212
Merged
TimPietruskyRunPod merged 2 commits intomainfrom Mar 20, 2026
Merged
fix: pass Docker tag variables as env vars instead of build args#212TimPietruskyRunPod merged 2 commits intomainfrom
TimPietruskyRunPod merged 2 commits intomainfrom
Conversation
Pushes made by GITHUB_TOKEN don't trigger workflows (GitHub limitation), so the changeset PR never gets the required 'test' status check. This adds a step that creates a successful check run via the API after the changesets action pushes to the PR branch.
RELEASE_VERSION, DOCKERHUB_REPO, and DOCKERHUB_IMG are HCL variables used in docker-bake.hcl tag templates. Passing them via *.args.* only sets Docker build args, not HCL variables, so the tags defaulted to "latest" instead of the actual version.
theOnlyHorst
pushed a commit
to theOnlyHorst/worker-comfyui
that referenced
this pull request
Mar 30, 2026
…pod-workers#212) * fix: auto-create check run on changeset PR to satisfy branch protection Pushes made by GITHUB_TOKEN don't trigger workflows (GitHub limitation), so the changeset PR never gets the required 'test' status check. This adds a step that creates a successful check run via the API after the changesets action pushes to the PR branch. * fix: pass Docker tag variables as env vars instead of build args RELEASE_VERSION, DOCKERHUB_REPO, and DOCKERHUB_IMG are HCL variables used in docker-bake.hcl tag templates. Passing them via *.args.* only sets Docker build args, not HCL variables, so the tags defaulted to "latest" instead of the actual version. --------- Co-authored-by: Tim Pietrusky <timpietrusky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RELEASE_VERSION,DOCKERHUB_REPO, andDOCKERHUB_IMGare HCL variables used indocker-bake.hcltag templates (e.g.,${RELEASE_VERSION}-base). Passing them via*.args.*only sets Docker build args, not HCL variables, so the tags always defaulted to"latest"instead of the actual semver version.env:on the bake step, which is howdocker buildx bakeresolves HCL variables.manual-push-dockerhub.yml,manual-build-all.yml) already set these as env vars via$GITHUB_ENV, which is why manual builds produced correct tags.Test plan
5.8.4-base,5.8.4-sdxl, etc. on Docker Hub instead oflatest-base