ci: minor fix for repo checkout #358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ayush-panta <[email protected]>
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| with: | ||
| ref: ${{ github.head_ref }} | ||
| ref: ${{ github.head_ref || 'main' }} |
Contributor
There was a problem hiding this comment.
Is it okay to not add the same to samcli-vm.yaml? Also won't this suffer from the same "PR from a fork" issue?
Edit - Correct me if I'm wrong but I think ref can just be main for samcli-vm.yaml since it doesn't run on PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Made it so that samcli-direct will check out main when it cannot find the PR branch. It seems when ref is not set at all it defaults to checking out main, but when ref is set to something that does not exist (eg a deleted branch after merging a PR) this behavior does not hold.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.