Skip to content

Add Dwarven rock cake helper plugin #8318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

YuvalPeretzAtBay
Copy link

No description provided.

@runelite-github-app
Copy link

runelite-github-app bot commented Jun 29, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Jun 29, 2025

Internal use only: Reviewer details Maintainer details

@pajlada
Copy link
Contributor

pajlada commented Jun 29, 2025

a dwarven rock cake cannot kill you - what purpose does the plugin serve?

also, you should not be launching JOptionPane dialogs without clear user input in a swing UI or something

@pajlada pajlada added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 29, 2025
@YuvalPeretzAtBay
Copy link
Author

@pajlada
So when you "eat" the cake, it can lower you to 2 HP.
When you "guzzle" the cake, you can go 1 HP and even die.
The plugin lets you "guzzle" the cake without it killing you.

This is helpful to the NMZ where you want to lower your HP to 1 to stay longer, and the alert that this plugin adds is also helping there.

Is it possible to add the plugin or is in not that useful in your view?

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jun 30, 2025
@coopermor
Copy link
Contributor

Guzzling a dwarven rock cake will not kill you. You can spam click it at 1HP and it will only hit you for 0. You would have to take damage from another source (like an overload) in order to die, which this plugin wouldn't really prevent.

@YuvalPeretzAtBay
Copy link
Author

@coopermor
Thank you for clarifying it!
After further investigation I can see that this is the behaviour.
I will close the PR.
Have a good one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants