Skip to content

Deathdotter #8313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Deathdotter #8313

wants to merge 3 commits into from

Conversation

dmgear
Copy link
Contributor

@dmgear dmgear commented Jun 28, 2025

Added new feature so players can toggle on/off disabling the plugin when they're in a pvp zone and added some new tags.

@runelite-github-app
Copy link

runelite-github-app bot commented Jun 28, 2025

@riktenx
Copy link
Contributor

riktenx commented Jun 28, 2025

This submission is not reviewable in its current state given the conflicts. Please rebase your fork from the upstream repo, it appears you have not done so since this plugin was first added.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 28, 2025
@dmgear dmgear requested a review from a team as a code owner June 28, 2025 21:59
@runelite-github-app runelite-github-app bot added package change and removed waiting for author waiting for the pr author to make changes or respond to questions plugin added labels Jun 28, 2025
@tylerwgrass
Copy link
Member

please review the steps here
https://github.com/runelite/plugin-hub?tab=readme-ov-file#updating-a-plugin

@runelite-github-app
Copy link

runelite-github-app bot commented Jun 28, 2025

Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Contributor

riktenx commented Jun 28, 2025

Their upstream remote was previously incorrect, I've given them commands to fix it.

@riktenx
Copy link
Contributor

riktenx commented Jun 28, 2025

The diff looks good now but please review the feedback w.r.t. System.out

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 29, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants