Add devcontainer support - #1207
Open
PragTob wants to merge 2 commits into
Open
Conversation
I really like to do dev from within devcontainers these days. So, I thought I'd add one here to make contributing a little easier for people who like devcontainers. I tried to reuse what I could (`Dockerfile`, compose file) and add the documentation where necessary/appropriate. Added some other goodies/tools to the Dockerfile that seemed helpful and as it was my understanding that the Dockerfile is used for development (not deployment) I thought that was good. THe other additions here are around yarn, as the yarn install resolved to a much newer version which apparently generates and needs these files. Thought I'd leave that in but happy to split it out.
Collaborator
Author
|
To not interfere with the main PR description: Thank you a lot for your long and continued support on this app, that I've used for free for more than a decade 💚 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really like to do dev from within devcontainers these days.
So, I thought I'd add one here to make contributing a little
easier for people who like devcontainers.
I tried to reuse what I could (
Dockerfile, compose file) andadd the documentation where necessary/appropriate.
Added some other goodies/tools to the Dockerfile that seemed
helpful and as it was my understanding that the Dockerfile is used
for development (not deployment) I thought that was good.
THe other additions here are around yarn, as the yarn install
resolved to a much newer version which apparently generates and
needs these files. Thought I'd leave that in but happy to split
it out.
in a separate commit
node_modulesthat I think were left there by accident are removed.