Add the possibility to provide a header image and add Dresden.rb logos #1136
Conversation
app/helpers/home_helper.rb
Outdated
| File.join('labels', Whitelabel[:label_id], 'header.png') | ||
| end | ||
|
|
||
| def header? |
There was a problem hiding this comment.
IMHO this method name is to generic and doesn't communicate the intend. How about header_image_available?, uses_header_image?
There was a problem hiding this comment.
I agree those names are much better!
app/helpers/home_helper.rb
Outdated
| end | ||
| end | ||
|
|
||
| def header_path |
There was a problem hiding this comment.
| def header_path | |
| def header_image_path |
|
In general I like the idea. Result on Mobil looks "strange", but if that is fine for you. |
richardboehme
force-pushed
the
dresdenrb-logo
branch
from
593ac44 to
da24ac7
Compare
Mh 🤔 To me it looks exactly the same as the other logo + heading variant? Both are just hidden on mobile or not? Maybe there is something different on my device? Local version of Dresden.rb: Live Version of Hamburg user group: |
was thinking about the small logo in the header, in the top left corner. For me, it felt like a little bit hard to recognise. |
Oh I see! Well I guess this is related to the the logo itself, which does not set itself apart from the background to well. I'll see if I can make it a bit bigger so that it's more prominent. |
richardboehme
force-pushed
the
dresdenrb-logo
branch
from
da24ac7 to
eb34f4a
Compare
I increased the logo size a bit which should be the best we can do for now. |
|
@salzig Sorry for pinging, anything we can do to get this merged? 😅 |
2 participants
Hey! We now have logos 🧑🍳
Because I really like the typography that comes with our logo (see the little ruby as the dot!) I thought it might be a cool idea to provide the possibility to add a header image instead of the logo + h1 combo that remains the default of course. Let me know what you think about this! If you don't like that it's fine and I'm gonna close this PR and create a new one to just change our logo.
This PR also fixes the favicon of our meetup page.